all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: daanturo <daanturo@gmail.com>,
	"Stefan Monnier" <monnier@iro.umontreal.ca>,
	"Mattias Engdegård" <mattiase@acm.org>
Cc: 59333@debbugs.gnu.org
Subject: bug#59333: [PATCH] Define macro dlet*
Date: Thu, 17 Nov 2022 09:25:00 +0200	[thread overview]
Message-ID: <83leoadovn.fsf@gnu.org> (raw)
In-Reply-To: <0e8ca5ce-a413-0dd0-c62e-647d19953a3b@gmail.com> (message from daanturo on Thu, 17 Nov 2022 14:13:35 +0700)

> Date: Thu, 17 Nov 2022 14:13:35 +0700
> From: daanturo <daanturo@gmail.com>
> 
> The dlet breakage comes as much surprise to me. There's not even a
> single entry in NEWS that mentions it.

dlet was new in Emacs 28, and the change you mention was done before
Emacs 28 was released.  So NEWS just mentions the introduction of
dlet, and that is enough.

> I would rather prefer b72f88518b89560accf740a4548368863e6238e0 be
> reverted, though. But maybe that's fine if the majority of maintainers
> agree with that change. But please mention similar breakages more
> universally.

I can only understand the breakage if someone picked up dlet as
originally implemented on master, before Emacs 28 was released.  In
that case, it's the risk people take when they follow the development
code too closely.

As for the patch, I'd like to hear opinions about the need for dlet*.

Thanks.





  reply	other threads:[~2022-11-17  7:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  7:13 bug#59333: [PATCH] Define macro dlet* daanturo
2022-11-17  7:25 ` Eli Zaretskii [this message]
2022-11-17  7:40   ` Daan Ro
2022-11-19  4:37     ` Jean Louis
2022-11-17 13:22   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-17 13:36     ` Mattias Engdegård
2022-11-25  0:14       ` Stefan Kangas
2022-11-19  4:28   ` Jean Louis
2022-11-19  4:47 ` Jean Louis
2022-11-19  5:29   ` daanturo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83leoadovn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59333@debbugs.gnu.org \
    --cc=daanturo@gmail.com \
    --cc=mattiase@acm.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.