From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: ackerleytng@gmail.com, 59381@debbugs.gnu.org
Subject: bug#59381: Should xref--marker-ring be per-window?
Date: Sat, 19 Nov 2022 21:53:26 +0200 [thread overview]
Message-ID: <83leo67mbt.fsf@gnu.org> (raw)
In-Reply-To: <86leo6ai85.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 19 Nov 2022 20:53:46 +0200)
> Cc: 59381@debbugs.gnu.org
> From: Juri Linkov <juri@linkov.net>
> Date: Sat, 19 Nov 2022 20:53:46 +0200
>
> > While using xref (xref-find-definitions and xref-find-references, etc)
> > in separate windows, I hit M-, to pop the marker stack expecting that
> > each window should have a separate stack.
> >
> > However, it seems that the entire emacs instance shares a single
> > xref--marker ring.
> >
> > Could we have separate xref--marker-rings per window, or some
> > configuration option to enable that?
>
> Ideally, making an existing variable window-local should be as easy
> as making it buffer-local, e.g.:
>
> (make-variable-buffer-local 'xref--history)
> ->
> (make-variable-window-local 'xref--history)
>
> But we are not here so far.
I don't think it's that simple. Windows are much more ephemeral than buffers;
for example, "C-x 2" followed by "C-x 1" or "C-x 0" deletes one of the windows.
What do we want to happen with the "window-local" xref stack in that case?
My guess is that the OP wanted to have control on when M-. pushes locations to
the last used stack or begin a new stack. Because only the user knows when
M-. begins a new series of searches. So I think it is better to offer a
separate command for exercising just such control.
next prev parent reply other threads:[~2022-11-19 19:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 5:29 bug#59381: Should xref--marker-ring be per-window? Ackerley Tng
2022-11-19 18:53 ` Juri Linkov
2022-11-19 19:53 ` Eli Zaretskii [this message]
2022-11-19 22:01 ` Ackerley Tng
2022-11-20 7:09 ` Eli Zaretskii
2022-11-20 17:00 ` Dmitry Gutov
2022-11-20 17:32 ` Eli Zaretskii
2022-11-20 18:11 ` Ackerley Tng
2022-11-20 18:22 ` Eli Zaretskii
2022-11-20 23:01 ` Dmitry Gutov
2022-11-21 7:42 ` Juri Linkov
2022-11-24 3:16 ` Dmitry Gutov
2022-11-20 2:52 ` Dmitry Gutov
2022-11-20 7:59 ` Eli Zaretskii
2022-11-20 23:17 ` Dmitry Gutov
2022-11-21 13:14 ` Eli Zaretskii
2022-11-22 2:46 ` Ackerley Tng
2022-11-24 3:28 ` Dmitry Gutov
2022-11-24 14:17 ` Dmitry Gutov
2022-11-24 23:42 ` Ackerley Tng
2022-11-24 23:59 ` Dmitry Gutov
2022-11-25 0:28 ` Ackerley Tng
2022-11-25 1:02 ` Dmitry Gutov
2022-11-24 3:19 ` Dmitry Gutov
2022-11-24 7:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83leo67mbt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59381@debbugs.gnu.org \
--cc=ackerleytng@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.