From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Wed, 01 Feb 2023 19:38:46 +0200 Message-ID: <83lelhz3o9.fsf@gnu.org> References: <834jsccepb.fsf@gnu.org> <83sffuap62.fsf@gnu.org> <83a622abpz.fsf@gnu.org> <8af34023-d3d7-a18d-54c5-f418515dea1c@gmx.at> <835ycp6v48.fsf@gnu.org> <7732128c-540b-9e38-0bf3-26c2496d2c0f@gmx.at> <83cz6v53e1.fsf@gnu.org> <9c7209b0-2af2-ab16-7b04-397d7d069025@gmx.at> <83357r5269.fsf@gnu.org> <83a61y3irr.fsf@gnu.org> <84c98406-5aea-de0e-67bb-10fffd5dd5ad@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32372"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tgbugs@gmail.com, emacs-devel@gnu.org, larsi@gnus.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 01 18:39:33 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNH51-00084E-Ti for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Feb 2023 18:39:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNH4S-0008Tu-Ek; Wed, 01 Feb 2023 12:38:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNH4M-0008Pw-Ks for emacs-devel@gnu.org; Wed, 01 Feb 2023 12:38:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNH4L-00017x-Jb; Wed, 01 Feb 2023 12:38:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1uKJypsGx4hxM/qe15pVoA9Hv754RQ5IRMDgoj+ADnY=; b=X2z8wOamJrMz HlKTrSTHWUN1W23V9JQRvAa7V81EskRpoRyBZXjoS4SGVM9qAW6hQ24Qn2txmKoetx0UG7F2qZWbA U9JtU5Ya+tXlyN0XblOSUjxbjuQh47LXfIa7WtnPFgJEKwu1UIeDcqgjeM1EgcsJf6suCszgiN6cn 7MixqKCfYgU8b9g7q3JRb2WkqQp6rhqwxvc0or0TMRxaW7L/SoJc0pUO7ggMHA7t+tzewhHwBBarn K7qv5aTmWIiYr687zXa0b8Gp/WcWKipU2ACWkoJnmoZuUBhyC2rIXJSkc//yRTa3ioYE+CKjDmxKJ qIOviasladSvHU/DDuH7mA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNH4K-0005Fc-WC; Wed, 01 Feb 2023 12:38:49 -0500 In-Reply-To: <84c98406-5aea-de0e-67bb-10fffd5dd5ad@gmx.at> (message from martin rudalics on Wed, 1 Feb 2023 11:45:06 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302870 Archived-At: > Date: Wed, 1 Feb 2023 11:45:06 +0100 > Cc: tgbugs@gmail.com, emacs-devel@gnu.org, larsi@gnus.org > From: martin rudalics > > There's worse as I just noticed. 'display-buffer-avoid-small-windows': > > - Invariably affects, once set, 'get-lru-window' which can be used > anywhere outside the scope of 'display-buffer'. So it's not only a > misnomer but a typical example of a collateral effect. > > - Is described in section 29.15.4 of the Elisp manual which talks about > "older options" some of them candidates for obsoletion. > > - Ignores that an action alist entry of that type already existed. It's > called 'window-min-height' and could have been easily used here. Is this related to display-buffer-use-least-recent-window and/or window-bump-use-time? Or is this another set of issues? Would it be possible to modify the effect of display-buffer-avoid-small-windows so that it works via the window-min-height alist entry? > Just that any such option should never be used in 'get-lru-window' but > exclusively in functions that pertain to 'display-buffer'. I see.