From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Small bug-reference.el change; safe enough for emacs-29 Date: Sun, 05 Feb 2023 20:42:27 +0200 Message-ID: <83lelcq7ho.fsf@gnu.org> References: <87o7q8x8qo.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26036"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 05 19:42:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOjyJ-0006d7-UC for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Feb 2023 19:42:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOjxz-0002RL-Ib; Sun, 05 Feb 2023 13:42:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOjxx-0002RA-Vw for emacs-devel@gnu.org; Sun, 05 Feb 2023 13:42:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOjxx-00012K-DN for emacs-devel@gnu.org; Sun, 05 Feb 2023 13:42:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wBehSNca8GyiJrn5nCiMXhDBAuTOv1SVS1l63LI2tvs=; b=V8zYRudxqZBI frcDxKUqo2rCR9qDdvldbBpo9t4C+j0ZdIE9h462I1dVq1uKH4SYcW8aFd0PG4d75Zmd4LmJnAgBM SvZmLz4dLgkLHA/DhAqg8sowtajFEqJrcrQgEXqYp0i29upXEeu4hfmzTsLUyY/zrVTJy3uEJTYNx 73rRw8uVsePimJTEDFUcaxyWsN1gAqCM8ZSRJw65U5v8gdKylZuerFOf9eH8ZxTvI0zB4Wv7WjWve FK4EiHmiZVEmJVMQ6sQ0VJ676cmEBje5JUEX6egJHbXNT4asv+6HvfLqkcLwi7aCnFi2HDq1j4vp3 ydaFqwNaBeKjG/baJEuksg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOjxv-0007jl-QP; Sun, 05 Feb 2023 13:42:16 -0500 In-Reply-To: <87o7q8x8qo.fsf@gnu.org> (message from Tassilo Horn on Sun, 05 Feb 2023 19:26:27 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303009 Archived-At: > From: Tassilo Horn > Date: Sun, 05 Feb 2023 19:26:27 +0100 > > Hi Eli & all, > > I'd like to apply the below patch. It just moves the > bug-reference-auto-setup-functions init value out of the defvar and sets > it afterwards. That's because if a package like mu4e in the concrete > case (https://github.com/djcb/mu/pull/2428) uses > > (add-hook 'bug-reference-auto-setup-functions > #'mu4e--view-try-setup-bug-reference-mode) > > to add bug-reference auto-setup for its modes *before* bug-reference > itself is loaded, the stock auto-setup functions defined by > bug-reference would not be added when bug-reference gets loaded later > on. OK.