From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62763: 29.0.90; failed test during build Date: Tue, 11 Apr 2023 16:42:17 +0300 Message-ID: <83leiya62u.fsf@gnu.org> References: <835ya3aqtx.fsf@gnu.org> <83o7nua7v6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12253"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62763@debbugs.gnu.org To: Tim Heaney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 11 15:42:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmEGR-0002y0-KQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Apr 2023 15:42:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmEGA-0007QT-Ox; Tue, 11 Apr 2023 09:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmEG2-0007Pm-PI for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 09:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmEG2-0000vu-H8 for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 09:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmEG2-0005WT-2e for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Apr 2023 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62763 X-GNU-PR-Package: emacs Original-Received: via spool by 62763-submit@debbugs.gnu.org id=B62763.168122050321203 (code B ref 62763); Tue, 11 Apr 2023 13:42:02 +0000 Original-Received: (at 62763) by debbugs.gnu.org; 11 Apr 2023 13:41:43 +0000 Original-Received: from localhost ([127.0.0.1]:36916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmEFj-0005Vv-9o for submit@debbugs.gnu.org; Tue, 11 Apr 2023 09:41:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmEFg-0005Vi-GY for 62763@debbugs.gnu.org; Tue, 11 Apr 2023 09:41:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmEFa-0000p9-SY; Tue, 11 Apr 2023 09:41:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nyb5nlZ4/BgA6qZrHdtIueLTgwRJByANZOyq+mswAxk=; b=mnkIDx7FBzFnMdU0qlzf tMEOIs26gukUqWIQuzGXBejXmCt2+8CUaC26Dt4lEfFc02CnYziI16Q96FjwMOfMrefzFqkKhZW32 gROzGrOPO78+yQeeilRaNxOA/l21gkmLGDUhEeldjNMBLmIVndG3fz2J5D/EcIqjiVMYx179qVf3X 1EojGa1jPBcWU/Ne6C13+ME/oC/SPPrWJeaIAl1ipxo+FlJn/YsBsafdQKrHdBRFYDjcKxiuESRGT MgKMZtKgctTuM2bhOKmlyCAqcEdYli57O8Oj2ipDXaiH1vPQ3PutcOxryYOVyHwW0QVrpk3prRFF1 Tp9l8sLTVYCGUA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmEFa-00054h-3h; Tue, 11 Apr 2023 09:41:34 -0400 In-Reply-To: (message from Tim Heaney on Tue, 11 Apr 2023 09:23:11 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259645 Archived-At: > From: Tim Heaney > Date: Tue, 11 Apr 2023 09:23:11 -0400 > Cc: 62763@debbugs.gnu.org > > Here is the *Messages* buffer after the first part > > For information about GNU Emacs and the GNU system, type C-h C-a. > Loading wallpaper...done > You can run the command ‘load-library’ with M-x loa-l > Loading wallpaper...done > #s(wallpaper-setter "XFCE" "xfconf-query" wallpaper-xfce-command-args #[0 "! \0! \0 " [getenv > "DESKTOP_SESSION" ("xubuntu" "ubuntustudio") "XFCE" xdg-current-desktop] 2] nil nil) Thanks. Does the patch below fix the error? diff --git a/test/lisp/image/wallpaper-tests.el b/test/lisp/image/wallpaper-tests.el index 2e4e360..c4167ad 100644 --- a/test/lisp/image/wallpaper-tests.el +++ b/test/lisp/image/wallpaper-tests.el @@ -129,12 +129,16 @@ wallpaper-set/calls-wallpaper-set-function (should (equal called fil-jpg))))) (ert-deftest wallpaper--find-command/return-string () - (should (or (not (wallpaper--find-command)) - (stringp (wallpaper--find-command))))) + (let ((cmd (wallpaper--find-command))) + (should (or (not cmd) + (stringp cmd))))) (ert-deftest wallpaper--find-command-args/return-list () - (should (or (not (wallpaper--find-command-args)) - (listp (wallpaper--find-command-args))))) + (let ((cmdargs (wallpaper--find-command-args))) + (if (functionp cmdargs) + (setq cmdargs (funcall cmdargs))) + (should (or (not cmdargs) + (listp cmdargs))))) (ert-deftest wallpaper--image-file-regexp/return-string () (should (stringp (wallpaper--image-file-regexp))))