From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Thu, 13 Jul 2023 22:08:20 +0300 Message-ID: <83lefj4okb.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21747"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 21:09:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qK1gh-0005Ts-J7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 21:09:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK1gU-0004TI-TA; Thu, 13 Jul 2023 15:09:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK1gU-0004TA-7S for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 15:09:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qK1gT-0004oc-VI for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 15:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qK1gT-0003bJ-QZ for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 15:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168927529513788 (code B ref 64596); Thu, 13 Jul 2023 19:09:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 13 Jul 2023 19:08:15 +0000 Original-Received: from localhost ([127.0.0.1]:40890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK1fj-0003aK-1K for submit@debbugs.gnu.org; Thu, 13 Jul 2023 15:08:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK1fe-0003a4-Pw for 64596@debbugs.gnu.org; Thu, 13 Jul 2023 15:08:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK1fZ-0004Dm-A2; Thu, 13 Jul 2023 15:08:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Tdd9U6CBT5HOFeFG1PALo4B5Pa+VNLVeNoWE0/oGWUE=; b=J2aEH88Q+T1a O6+HmYQ7ZxHNBJpNpD1BAmJMBHrmXtPkXi9FTb46gXiM6dddpb1IeUa/6PNWPiEnbzL1CDugQ+0jo mLZqqYZlIzP++KRnbmDFIkLrmeHVHJOsFAbT7v0TUK+2TagYNQ9V00sPw4A5F2OmLohz8AZLT7xOh +E8K6WtS6ukPlbZs2fqAgEnO4MthS50ErFU0/7Sd98B1kp/BC2pCh1+rMRsizes6z4SwgHtU7B2nc byBy9pubAF5nSv7LoKYLNL/LxSOTPjyQDhGhw6zjwNaGL7IauqmtqzLUFanASiauII7dMZNPdtu+G wfcDA0eeHbY7jMhajDfMhw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK1fY-0002yZ-Q3; Thu, 13 Jul 2023 15:08:05 -0400 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265045 Archived-At: > Cc: 64596@debbugs.gnu.org > Date: Thu, 13 Jul 2023 13:20:23 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > AFAIU, the purpose of disabling redisplay optimizations is avoiding the > > situation when the modification flag is unset in the buffer, but the > > buffer was actually modified, and has to be redrawn. > > If my understanding is correct, > > current_buffer->prevent_redisplay_optimizations_p = true does not belong > > to `force-mode-line-update', but rather to `restore-buffer-modified-p'. > > I strongly suspect it doesn't belong in `force-mode-line-update`, indeed. To the ALL branch or to both of them? > > Stefan will tell, but I'm quite sure he wrote that FIXME because > > removing that line caused regression in some situation. > > Nope. I put the FIXME simply because I realized that the code doesn't > make sense: if that line is sometimes necessary, then I'm pretty sure it's > not always sufficient. Then I guess you or Ihor (or both) should try removing that line and run with that for a while. Alternatively, maybe in the case of ALL non-nil the code should set the prevent_redisplay_optimizations_p flag of all the buffers that are displayed in some window, since some redisplay optimizations are not eligible when the mode-line is about to be updated.