From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63896: [PATCH] Support annotating and sorting the project list during completion Date: Thu, 24 Aug 2023 08:29:13 +0300 Message-ID: <83lee1qa8m.fsf@gnu.org> References: <83v8g240g6.fsf@gnu.org> <2688fc0b-6afb-7f13-1805-bf79b0fcabd3@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15127"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 63896@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 07:29:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZ2uE-0003iy-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 07:29:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ2tv-0002h4-Pp; Thu, 24 Aug 2023 01:28:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ2tu-0002gq-Cg for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 01:28:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZ2tu-0003at-47 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 01:28:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZ2tx-0006h0-Sa for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 01:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 05:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63896-submit@debbugs.gnu.org id=B63896.169285494025716 (code B ref 63896); Thu, 24 Aug 2023 05:29:01 +0000 Original-Received: (at 63896) by debbugs.gnu.org; 24 Aug 2023 05:29:00 +0000 Original-Received: from localhost ([127.0.0.1]:35898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ2tw-0006gi-0z for submit@debbugs.gnu.org; Thu, 24 Aug 2023 01:29:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ2tu-0006gV-Je for 63896@debbugs.gnu.org; Thu, 24 Aug 2023 01:28:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ2tl-0003aZ-0B; Thu, 24 Aug 2023 01:28:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SefDhveQbNjDfAfblKdSCddqlAzXnbSZtPOyYEDj/5U=; b=rQ9j29uy5v6K iWCzGh8tJ4TkdXS096ho+5KuTy7Z/Z4Nw6ewwKhrN34tZ873afyKjW7wXpm56Skzonir/xOuUNJIf CqkOKobzZqCg4H1e/ebNBx6vOGglPb58ipOJR+ZPyYNdYopyXYWBVjY4GfwGdiRRmjWBmwwkfYxEi rbPqlCqYMslG9n0oBbUODvYw7O+vjnmQFLkItyTfRCvr6pFmoG91m5/i0dqC9kmxbcmDzknkgF1He yJZDCgSulbpBFPIQjUYeQYdmx6yIM3R6saSLAOUX6G9go8YUi1FfHm4Eltu7YDG2CSXkB3PcO+m6V UI4xsdQ4FxMDyYXTEOUE+A==; In-Reply-To: <2688fc0b-6afb-7f13-1805-bf79b0fcabd3@gutov.dev> (message from Dmitry Gutov on Thu, 24 Aug 2023 04:54:44 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268299 Archived-At: > Date: Thu, 24 Aug 2023 04:54:44 +0300 > Cc: 63896@debbugs.gnu.org > From: Dmitry Gutov > > On 05/06/2023 14:23, Eli Zaretskii wrote: > >> + (format-mode-line mode-line-process nil nil buf))) > > Do you really need to call format-mode-line? My advice is to stay > > away of that function: it could have unpleasant side effects. > > Does calling format-mode-line trigger extra redisplays or something? > That sounds unexpected. It reuses parts of the redisplay's code, yes. Depending what's in the format variable passed to format-mode-line, that could cause a variety of surprises, especially if :eval forms are involved. It could also temporarily select another window and/or buffer, if the respective arguments are not omitted, which could also be unexpected. IMO, this function should be used sparing and with caution.