From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65049: Minor update to the repro steps Date: Mon, 28 Aug 2023 15:12:48 +0300 Message-ID: <83ledvicvz.fsf@gnu.org> References: <83y1iruky1.fsf@gnu.org> <83il9qom6k.fsf@gnu.org> <86v8dandhq.fsf@mail.linkov.net> <83bkf1woy3.fsf@gnu.org> <835y57tf23.fsf@gnu.org> <87edjvp6ev.fsf@gmail.com> <83350btdw8.fsf@gnu.org> <831qftspal.fsf@gnu.org> <35b50832-e9ca-9f57-fad6-68621d9b42e7@gutov.dev> <83pm3dqbtp.fsf@gnu.org> <789dacd3-8e62-74ad-f691-5b48cb1d678b@gutov.dev> <2f6986e7-f96b-98bd-4581-7503bb01b111@gutov.dev> <83ttsnoda5.fsf@gnu.org> <49d5e741-f97d-ae4d-f79c-ec418051d868@gutov.dev> <83v8d2kx1g.fsf@gnu.org> <8be534f8-9f03-5de6-53c8-76be0f9456fa@gutov.dev> <831qfpkpx7.fsf@gnu.org> <02a7f7fe-74c2-a59a-7d7d-1da9d3270c8a@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29562"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65049@debbugs.gnu.org, habamax@gmail.com, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 28 14:14:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qab8Q-0007Tu-6t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Aug 2023 14:14:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qab82-000635-87; Mon, 28 Aug 2023 08:13:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qab80-00062a-QY for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 08:13:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qab80-0004QE-I4 for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 08:13:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qab86-0003FY-BY for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2023 08:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65049 X-GNU-PR-Package: emacs Original-Received: via spool by 65049-submit@debbugs.gnu.org id=B65049.169322480912445 (code B ref 65049); Mon, 28 Aug 2023 12:14:02 +0000 Original-Received: (at 65049) by debbugs.gnu.org; 28 Aug 2023 12:13:29 +0000 Original-Received: from localhost ([127.0.0.1]:47275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qab7Z-0003Ed-6A for submit@debbugs.gnu.org; Mon, 28 Aug 2023 08:13:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qab7X-0003ER-6a for 65049@debbugs.gnu.org; Mon, 28 Aug 2023 08:13:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qab7J-0004Ix-VE; Mon, 28 Aug 2023 08:13:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uDhf/5meJPWmWphKqm29TnC+WEGf7mhTEZQ0+elRFlQ=; b=By1nJeNPJ019 akfdpauzJNx+a/qbvMYBuKIcZw9aDO98GRDlOaXhVNbn6umMEtfKL8GnSQFDqIF/ImpshRohmeh4M xp8+Ft0K6w+5TtOjm+Tv8xyT5axVPSC33nf1ofzl25JL16GBZ2IikTscdIT1r351JHoxNn9dZPP/q Ff1IrmV5qI2uSu5pO59akOowJVZcc0G+k78eRNnwOc78Lo49X9qXJfnRQQkVDI6u36Eg6V8AoX03J LwNKGruzY/gJsT7E9QCK45evgTdsNk1eAt2LZjWq0GlvWi6LKQ2kJJZrLCYLG94vTm9IdAna64YDt NDkoGRYxQg0xipIfP7FGzQ==; In-Reply-To: <02a7f7fe-74c2-a59a-7d7d-1da9d3270c8a@gutov.dev> (message from Dmitry Gutov on Mon, 28 Aug 2023 01:32:57 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268619 Archived-At: > Date: Mon, 28 Aug 2023 01:32:57 +0300 > Cc: juri@linkov.net, habamax@gmail.com, 65049@debbugs.gnu.org > From: Dmitry Gutov > > >> Regarding your paragraph above about mojibake, though. That makes a lot > >> of sense, but I feel I have to stress: this mechanism doesn't work for > >> vc-root-diff (C-x v D). > > > > Not sure I understand. Can you show a recipe for "doesn't work"? > > It's the same recipe as what you proposed I test (a file with dos line > ending on unix). But you don't even have to test that. > > Try edebug-instrumenting vc-diff-internal and then calling vc-root-diff > anywhere (C-x v D). When the execution reaches the line that we have > been discussing, you'll see that (vc-coding-system-for-diff (car files)) > evaluates to 'undecided because (car files) is a directory. > > So this mechanism is always unused in vc-root-diff. OK, but in that case 'undecided' is the best guess we can come up with. It basically lets Emacs guess when it actually sees the stuff in the diffs, while reading it into a buffer.