From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67269: 30.0.50; italic face fallback does not assume italic properties Date: Sun, 19 Nov 2023 08:37:55 +0200 Message-ID: <83leaul03g.fsf@gnu.org> References: <87jzqejn8f.fsf.ref@yahoo.com> <87jzqejn8f.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18388"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67269@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 19 07:39:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4bSp-0004bM-O0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Nov 2023 07:39:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4bSY-0003Gv-3n; Sun, 19 Nov 2023 01:39:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4bSO-0003GL-V0 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 01:39:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4bSO-0001I9-Mo for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 01:39:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4bSP-0005vi-Oz for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 01:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 06:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67269 X-GNU-PR-Package: emacs Original-Received: via spool by 67269-submit@debbugs.gnu.org id=B67269.170037590422716 (code B ref 67269); Sun, 19 Nov 2023 06:39:01 +0000 Original-Received: (at 67269) by debbugs.gnu.org; 19 Nov 2023 06:38:24 +0000 Original-Received: from localhost ([127.0.0.1]:49811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4bRo-0005uH-6u for submit@debbugs.gnu.org; Sun, 19 Nov 2023 01:38:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4bRl-0005tp-Er; Sun, 19 Nov 2023 01:38:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4bRe-0001AJ-Ni; Sun, 19 Nov 2023 01:38:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qecxywyNtmDS2Bri6G30zFqXbBm5RKVHZZlBROKVV7w=; b=qYpQCXzcRwEL ld3S838eGdK1gdPWA2WdK9++vyAAZIg0pKWCLmh1540wPxxuVBYMB0aEk3UTHiuqYAz+bIhLYEiAM uRTkXe5w9gXFOdMJCAM8M0feecR8RXlzjBOcW7879jLnlanoiZ366WQ/DVW6kC7jjGJIIZGvwakif ovtY4TVi3ogOzb/49xqc/yUE4iEavUAwaas83n1RmZM4L4zf7b8lPATz9nxzqJcsVIJZIBxaYPIIT 7h97MfZ39Kweh7JDZXs8/saAhrx10dsbadOameKYMmdRAryOQYx2lD0uH0RuFy2NYfZ5eQJoCWt+q Tr0IctzWfgw6S4k+M2z2lw==; In-Reply-To: <87jzqejn8f.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274594 Archived-At: tags 67269 notabug thanks > Date: Sun, 19 Nov 2023 14:01:04 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > When the default font doesn't supply an Italic variant, the italic face > is assigned an underline propery in its place. But when the italic face > is merged with another face whose font does supply such a variant, the > underline is applied all the same while the slant that would ideally be > also is disregarded. > > Hence if the default font is set to Droid Sans Mono (with no Italic > variant) while shr-text is set to Times New Roman, italic text rendered > by shr: > > (shr-text italic) > > is underlined rather than slanted. Moreover, no underline or slant is > manifested if there is an Italic variant to the default font but not the > face being merged with italic, depriving such italic text of any visual > distinctiveness. I see no bug here. You are talking about faces defined with defface, which are always based on the default font. Given that fact, there's not much we can do here, except perhaps keep the :slant attribute together with :underline (although that's questionable, and I'm not sure we should do that). Removing the underline when a non-default font does have the italic variant is not TRT, since it will cause parts of the text appear with an underline and other parts without it. Basically, choosing a default font that doesn't have the italic variant is simply a bad idea, so what you describe is a cockpit error, not an Emacs bug.