From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 23.1.93 pretest Date: Sat, 27 Feb 2010 17:29:44 +0200 Message-ID: <83k4tyd7dj.fsf@gnu.org> References: <87pr3rny7e.fsf@stupidchicken.com> <83fx4n122q.fsf@gnu.org> <833a0ndlo0.fsf@gnu.org> <83pr3qddl4.fsf@gnu.org> <83ljeed8zp.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1267285085 24606 80.91.229.12 (27 Feb 2010 15:38:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 27 Feb 2010 15:38:05 +0000 (UTC) Cc: lekktu@gmail.com, cyd@stupidchicken.com, schwab@linux-m68k.org, emacs-devel@gnu.org To: Lennart Borgman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 27 16:38:00 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NlOjw-0004iQ-7h for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2010 16:38:00 +0100 Original-Received: from localhost ([127.0.0.1]:35958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlOjv-0007iq-Jz for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2010 10:37:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NlOcR-0004Ru-2j for emacs-devel@gnu.org; Sat, 27 Feb 2010 10:30:15 -0500 Original-Received: from [140.186.70.92] (port=50805 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlOcQ-0004RR-6s for emacs-devel@gnu.org; Sat, 27 Feb 2010 10:30:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NlOcP-0003qy-8Z for emacs-devel@gnu.org; Sat, 27 Feb 2010 10:30:14 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:49699) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NlOcP-0003qf-1q for emacs-devel@gnu.org; Sat, 27 Feb 2010 10:30:13 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KYI00F00AVH6D00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sat, 27 Feb 2010 17:29:44 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.228.186.130]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYI00B2MB1CKE80@a-mtaout22.012.net.il>; Sat, 27 Feb 2010 17:29:37 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121443 Archived-At: > From: Lennart Borgman > Date: Sat, 27 Feb 2010 15:59:07 +0100 > Cc: lekktu@gmail.com, cyd@stupidchicken.com, > =09Andreas Schwab , emacs-devel@gnu.org >=20 > On Sat, Feb 27, 2010 at 3:54 PM, Eli Zaretskii wrote= : > >> From: Andreas Schwab > >> Cc: Juanma Barranquero , =C2=A0cyd@stupidchick= en.com, =C2=A0emacs-devel@gnu.org > >> Date: Sat, 27 Feb 2010 15:31:30 +0100 > >> > >> Eli Zaretskii writes: > >> > >> > But then how come this defense in uniscribe_check_otf did not = catch > >> > it? > >> > > >> > =C2=A0 /* Check the spec is in the right format. =C2=A0*/ > >> > =C2=A0 if (!CONSP (otf_spec) || Flength (otf_spec) < 3) > >> > =C2=A0 =C2=A0 return 0; > >> > >> Because `Flength (otf_spec) < 3' is bogus. =C2=A0It should be `X= INT (Flength > >> (otf_spec)) < 3'. > > > > Right you are. >=20 >=20 > Are you checking in a change? Andreas already did.