From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: recent commit broke src/dired.c on OSX Date: Sun, 25 Jul 2010 23:59:39 +0300 Message-ID: <83k4ojb7lw.fsf@gnu.org> References: <86iq4379w0.fsf@red.stonehenge.com> <86eier7942.fsf@red.stonehenge.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1280092426 7525 80.91.229.12 (25 Jul 2010 21:13:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Jul 2010 21:13:46 +0000 (UTC) Cc: lekktu@gmail.com, merlyn@stonehenge.com, emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 25 23:13:43 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Od8Vx-0005WW-9F for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 23:13:41 +0200 Original-Received: from localhost ([127.0.0.1]:57422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od8IY-0004Ij-IU for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 16:59:50 -0400 Original-Received: from [140.186.70.92] (port=59351 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Od8IQ-0004I7-LJ for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:59:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Od8IP-0001bw-LL for emacs-devel@gnu.org; Sun, 25 Jul 2010 16:59:42 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:45344) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Od8IO-0001Yh-6F; Sun, 25 Jul 2010 16:59:40 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L6400G00SSMID00@a-mtaout23.012.net.il>; Sun, 25 Jul 2010 23:59:39 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.61.30]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L6400E0USZEMS80@a-mtaout23.012.net.il>; Sun, 25 Jul 2010 23:59:39 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127800 Archived-At: > From: Dan Nicolaescu > Date: Sun, 25 Jul 2010 16:50:50 -0400 > Cc: emacs-devel@gnu.org, "Randal L. Schwartz" >=20 > >> =A0 =A0 char * > >> =A0 =A0 getcwd(char *buf, size_t size); > > > > This is already fixed on the trunk, assuming that in your build > > environment HAVE_GETCWD is set. >=20 > If HAVE_GETCWD is set there should not be a need to have a prototyp= e, > better just include unistd.h in that case. >=20 > IMHO we should get rid of all such extern declarations, and just > include the corresponding header files. 100% agreement.