From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs-diffs Digest, Vol 94, Issue 89 Date: Sat, 25 Sep 2010 09:25:30 +0200 Message-ID: <83k4mas2s5.fsf@gnu.org> References: <83zkv7rmpe.fsf@gnu.org> <83tylesyyk.fsf@gnu.org> <83r5gisxmp.fsf@gnu.org> <87fwwyzy0h.fsf@lola.goethe.zz> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285399550 30535 80.91.229.12 (25 Sep 2010 07:25:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 25 Sep 2010 07:25:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 25 09:25:49 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OzP8k-0008JS-QN for ged-emacs-devel@m.gmane.org; Sat, 25 Sep 2010 09:25:47 +0200 Original-Received: from localhost ([127.0.0.1]:38090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzP8j-0004HI-VG for ged-emacs-devel@m.gmane.org; Sat, 25 Sep 2010 03:25:45 -0400 Original-Received: from [140.186.70.92] (port=48803 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzP8a-0004HB-Ra for emacs-devel@gnu.org; Sat, 25 Sep 2010 03:25:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzP8V-0000g8-SI for emacs-devel@gnu.org; Sat, 25 Sep 2010 03:25:36 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:60564) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzP8Q-0000fJ-9j; Sat, 25 Sep 2010 03:25:26 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L9A00400KFWRN00@a-mtaout20.012.net.il>; Sat, 25 Sep 2010 09:25:25 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.203.3]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9A004JPKMBB5A0@a-mtaout20.012.net.il>; Sat, 25 Sep 2010 09:25:24 +0200 (IST) In-reply-to: <87fwwyzy0h.fsf@lola.goethe.zz> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130829 Archived-At: > From: David Kastrup > Date: Fri, 24 Sep 2010 22:29:02 +0200 > > Eli Zaretskii writes: > > > Or maybe you mean that Stefan thought casting was not the best idea. > > In that case, I'd like Stefan's opinion on this one: > > > >> - int frame_lines = FRAME_LINES (frame); > >> + EMACS_INT frame_lines = FRAME_LINES (frame); > > > > I think down that lane lies madness, because we have lots of struct > > members that are Lisp integers, and assigning the result of XINT of > > every one of them to an EMACS_INT will significantly and unnecessarily > > increase our stack usage (on 64-bit machines). > > "Significantly"? Reality check. Yes, indeed. Take a look at GC some day, it uses up tens of thousands of recursive calls as a matter of routine. And even without GC, there are about 30 frames on the stack any time I debug Emacs. If we pacify -Wconversion by using EMACS_INT for every variable that sometimes gets assigned the result of XINT or XFASTINT, that could be quite a lot of memory waste.