From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: issues with recent doprnt-related changes Date: Fri, 06 May 2011 22:57:30 +0300 Message-ID: <83k4e3lhzp.fsf@gnu.org> References: <4DB50AB9.6060100@cs.ucla.edu> <83tydmaeo3.fsf@gnu.org> <4DB65FF1.5010003@cs.ucla.edu> <83aafb8p4a.fsf@gnu.org> <4DB8ABEA.3080503@cs.ucla.edu> <4DB9146D.2040702@cs.ucla.edu> <4DB9E5FF.9020506@cs.ucla.edu> <83d3k571ee.fsf@gnu.org> <4DC10012.8020809@cs.ucla.edu> <4DC1692B.1090101@cs.ucla.edu> <83ei4cnau6.fsf@gnu.org> <83vcxnlvl9.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1304711868 30397 80.91.229.12 (6 May 2011 19:57:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 May 2011 19:57:48 +0000 (UTC) Cc: 8545@debbugs.gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 06 21:57:44 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QIR9j-0004LQ-Ro for ged-emacs-devel@m.gmane.org; Fri, 06 May 2011 21:57:43 +0200 Original-Received: from localhost ([::1]:59091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIR9j-0001Cp-Fh for ged-emacs-devel@m.gmane.org; Fri, 06 May 2011 15:57:43 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:45820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIR9e-0001Cj-CE for emacs-devel@gnu.org; Fri, 06 May 2011 15:57:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QIR9Z-0004q8-Nl for emacs-devel@gnu.org; Fri, 06 May 2011 15:57:38 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:42295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIR9Z-0004pr-HS for emacs-devel@gnu.org; Fri, 06 May 2011 15:57:33 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LKS00500HTVF100@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Fri, 06 May 2011 22:57:31 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.228.234.175]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKS004ELI3R1AP0@a-mtaout20.012.net.il>; Fri, 06 May 2011 22:57:31 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139183 Archived-At: > From: Stefan Monnier > Cc: eggert@cs.ucla.edu, 8545@debbugs.gnu.org, emacs-devel@gnu.org > Date: Fri, 06 May 2011 14:13:06 -0300 > > note that "the position of the nul byte" is the same as "the length > of the list", so it's still <= MOST_POSITIVE_FIXNUM. It's only the > position after the nul byte that would overflow. But what about this code and its commentary (from next_element_from_c_string): /* IT's position can be greater IT->string_nchars in case a field width or precision has been specified when the iterator was initialized. */ if (IT_CHARPOS (*it) >= it->end_charpos) { /* End of the game. */ ... This happens when the iterator is initialized by reseat_to_string. Admittedly, it's not very practical to have such huge strings that are padded to an even larger width...