From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9772: bug#10155: OSX breakage Date: Tue, 29 Nov 2011 19:30:30 +0200 Message-ID: <83k46i6dl5.fsf@gnu.org> References: <4ED3AA79.8060605@lassnig.net> <838vn06swa.fsf@gnu.org> <4ED3DA30.1050006@cs.ucla.edu> <871usrh69t.fsf@gnu.org> <4ED4A5BE.80008@cs.ucla.edu> <4ED50F3A.8040207@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1322587880 14551 80.91.229.12 (29 Nov 2011 17:31:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Nov 2011 17:31:20 +0000 (UTC) Cc: mario@lassnig.net, 9960@debbugs.gnu.org, cyd@gnu.org, 9772@debbugs.gnu.org, 10155@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 29 18:31:13 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RVRWS-000871-Ge for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Nov 2011 18:31:12 +0100 Original-Received: from localhost ([::1]:36390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVRWR-0002q7-TY for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Nov 2011 12:31:11 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:39835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVRWO-0002oM-1Y for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 12:31:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVRWH-0000kE-TZ for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 12:31:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVRWH-0000k2-Rr for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 12:31:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RVRYE-0003o8-IL for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 12:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2011 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 9772-submit@debbugs.gnu.org id=B9772.132258796314597 (code B ref 9772); Tue, 29 Nov 2011 17:33:02 +0000 Original-Received: (at 9772) by debbugs.gnu.org; 29 Nov 2011 17:32:43 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVRXv-0003nN-1M for submit@debbugs.gnu.org; Tue, 29 Nov 2011 12:32:43 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVRXn-0003mw-IV; Tue, 29 Nov 2011 12:32:36 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LVF00600LZ0JM00@a-mtaout20.012.net.il>; Tue, 29 Nov 2011 19:30:24 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.228.122.78]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LVF005P5NAMASH0@a-mtaout20.012.net.il>; Tue, 29 Nov 2011 19:30:24 +0200 (IST) In-reply-to: <4ED50F3A.8040207@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 29 Nov 2011 12:33:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54431 Archived-At: > Date: Tue, 29 Nov 2011 08:58:34 -0800 > From: Paul Eggert > CC: Chong Yidong , mario@lassnig.net, 9772@debbugs.gnu.org, > 9960@debbugs.gnu.org, 10155@debbugs.gnu.org, > Eli Zaretskii > > You're right, on further thought Emacs itself needn't use stdalign, > and I've prepared a simpler patch (below) that omits all changes to > src/*. Gnulib now uses stdalign, though, and Emacs uses > multiple Gnulib modules such as sha256 that use stdalign, so > this patch still brings in the stdalign module for Gnulib's own > purposes. I understand that the only part needed for solving the problems with the missing declaration of `environ' is this: > === added file 'm4/environ.m4' > --- m4/environ.m4 1970-01-01 00:00:00 +0000 > +++ m4/environ.m4 2011-11-29 16:38:21 +0000 > @@ -0,0 +1,47 @@ > +# environ.m4 serial 6 > +dnl Copyright (C) 2001-2004, 2006-2011 Free Software Foundation, Inc. > +dnl This file is free software; the Free Software Foundation > +dnl gives unlimited permission to copy and/or distribute it, > +dnl with or without modifications, as long as this notice is preserved. > + > +AC_DEFUN_ONCE([gl_ENVIRON], > +[ > + AC_REQUIRE([gl_UNISTD_H_DEFAULTS]) > + dnl Persuade glibc to declare environ. > + AC_REQUIRE([gl_USE_SYSTEM_EXTENSIONS]) > + > + AC_CHECK_HEADERS_ONCE([unistd.h]) > + gt_CHECK_VAR_DECL( > + [#if HAVE_UNISTD_H > + #include > + #endif > + /* mingw, BeOS, Haiku declare environ in , not in . */ > + #include > + ], > + [environ]) > + if test $gt_cv_var_environ_declaration != yes; then > + HAVE_DECL_ENVIRON=0 > + fi > +]) IOW, the reason why lib/unistd.in.h didn't do its job is that HAVE_DECL_ENVIRON was not defined to zero. If that is true, I wonder if we could have a much smaller change that fixes just that single problem.