From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: mario@lassnig.net, 9960@debbugs.gnu.org, cyd@gnu.org,
9772@debbugs.gnu.org, 10155@debbugs.gnu.org
Subject: bug#9772: bug#10155: OSX breakage
Date: Tue, 29 Nov 2011 19:30:30 +0200 [thread overview]
Message-ID: <83k46i6dl5.fsf@gnu.org> (raw)
In-Reply-To: <4ED50F3A.8040207@cs.ucla.edu>
> Date: Tue, 29 Nov 2011 08:58:34 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Chong Yidong <cyd@gnu.org>, mario@lassnig.net, 9772@debbugs.gnu.org,
> 9960@debbugs.gnu.org, 10155@debbugs.gnu.org,
> Eli Zaretskii <eliz@gnu.org>
>
> You're right, on further thought Emacs itself needn't use stdalign,
> and I've prepared a simpler patch (below) that omits all changes to
> src/*. Gnulib now uses stdalign, though, and Emacs uses
> multiple Gnulib modules such as sha256 that use stdalign, so
> this patch still brings in the stdalign module for Gnulib's own
> purposes.
I understand that the only part needed for solving the problems with
the missing declaration of `environ' is this:
> === added file 'm4/environ.m4'
> --- m4/environ.m4 1970-01-01 00:00:00 +0000
> +++ m4/environ.m4 2011-11-29 16:38:21 +0000
> @@ -0,0 +1,47 @@
> +# environ.m4 serial 6
> +dnl Copyright (C) 2001-2004, 2006-2011 Free Software Foundation, Inc.
> +dnl This file is free software; the Free Software Foundation
> +dnl gives unlimited permission to copy and/or distribute it,
> +dnl with or without modifications, as long as this notice is preserved.
> +
> +AC_DEFUN_ONCE([gl_ENVIRON],
> +[
> + AC_REQUIRE([gl_UNISTD_H_DEFAULTS])
> + dnl Persuade glibc <unistd.h> to declare environ.
> + AC_REQUIRE([gl_USE_SYSTEM_EXTENSIONS])
> +
> + AC_CHECK_HEADERS_ONCE([unistd.h])
> + gt_CHECK_VAR_DECL(
> + [#if HAVE_UNISTD_H
> + #include <unistd.h>
> + #endif
> + /* mingw, BeOS, Haiku declare environ in <stdlib.h>, not in <unistd.h>. */
> + #include <stdlib.h>
> + ],
> + [environ])
> + if test $gt_cv_var_environ_declaration != yes; then
> + HAVE_DECL_ENVIRON=0
> + fi
> +])
IOW, the reason why lib/unistd.in.h didn't do its job is that
HAVE_DECL_ENVIRON was not defined to zero.
If that is true, I wonder if we could have a much smaller change that
fixes just that single problem.
next prev parent reply other threads:[~2011-11-29 17:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 15:36 OSX breakage Mario Lassnig
2011-11-28 16:48 ` Paul Eggert
2011-11-28 17:47 ` Eli Zaretskii
2011-11-28 19:00 ` Paul Eggert
2011-11-29 5:00 ` Chong Yidong
2011-11-29 9:27 ` Paul Eggert
2011-11-29 9:28 ` bug#9772: " Paul Eggert
2011-11-29 13:56 ` bug#9960: bug#10155: " Stefan Monnier
2011-11-29 16:58 ` Paul Eggert
2011-11-29 17:30 ` Eli Zaretskii [this message]
2011-11-29 18:22 ` bug#9960: " Paul Eggert
2011-11-30 2:45 ` bug#10155: bug#9772: " Chong Yidong
2011-11-30 4:04 ` Eli Zaretskii
2011-11-30 8:14 ` Chong Yidong
2011-11-30 11:15 ` bug#10155: " Mario Lassnig
2011-12-01 16:12 ` Paul Eggert
2011-11-30 17:48 ` bug#10155: " Jan Djärv
2011-11-29 16:39 ` bug#9772: " Eli Zaretskii
2011-11-30 2:27 ` Chong Yidong
2011-11-28 19:29 ` Randal L. Schwartz
2011-11-29 11:45 ` Ashish SHUKLA
2011-11-30 12:08 ` Carsten Mattner
2011-11-30 15:00 ` Ashish SHUKLA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k46i6dl5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=10155@debbugs.gnu.org \
--cc=9772@debbugs.gnu.org \
--cc=9960@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=mario@lassnig.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.