From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113221: Implement visual-order cursor motion. Date: Sun, 30 Jun 2013 17:54:50 +0300 Message-ID: <83k3lbd4xx.fsf@gnu.org> References: <8361wxdjo2.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1372604099 11336 80.91.229.3 (30 Jun 2013 14:54:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Jun 2013 14:54:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 30 16:55:00 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UtJ1n-0007g5-VL for ged-emacs-devel@m.gmane.org; Sun, 30 Jun 2013 16:55:00 +0200 Original-Received: from localhost ([::1]:56842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtJ1n-0005Am-ID for ged-emacs-devel@m.gmane.org; Sun, 30 Jun 2013 10:54:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtJ1k-0005AW-1u for emacs-devel@gnu.org; Sun, 30 Jun 2013 10:54:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtJ1j-0002Y1-6X for emacs-devel@gnu.org; Sun, 30 Jun 2013 10:54:55 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:42134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtJ1i-0002Up-VE for emacs-devel@gnu.org; Sun, 30 Jun 2013 10:54:55 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MP700300O0YLP00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sun, 30 Jun 2013 17:54:46 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MP70032RO3A5O90@a-mtaout20.012.net.il>; Sun, 30 Jun 2013 17:54:46 +0300 (IDT) In-reply-to: <8361wxdjo2.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161349 Archived-At: > Date: Sat, 29 Jun 2013 18:24:29 +0300 > From: Eli Zaretskii > CC: emacs-devel@gnu.org > > > > + (sit-for 0)) > > > > I think this deserves a comment, because I for one have no idea why > > it's here. > > It's probably my misunderstanding of something. If I remove sit-for, > invoking the command with N > 1 causes it to see the value of point > that is not updated. That is, if point is at position X and you > invoke > > C-u 10 > > then inside move-point-visually I see on the 2nd or 3rd call that > point is being reset back to its value before the first call. I found the reason: it was a bug. The code moved point by using information in the current glyph matrix, but did not invalidate the cursor position info in the matrix, so redisplay would not update the cursor position; calling sit-for forced a more thorough redisplay and "fixed" that. I fixed the code by invalidating the cursor location, and removed the call to sit-for.