From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15876: 24.3.50; Highly degraded performance between rev 114715 and 115006 Date: Wed, 11 Dec 2013 20:12:08 +0200 Message-ID: <83k3fb6yvb.fsf@gnu.org> References: <867gcdiqji.fsf@somewhere.org> <86fvr09z55.fsf@somewhere.org> <83fvr01du4.fsf@gnu.org> <8638n0nj9p.fsf@somewhere.org> <86bo1eaelv.fsf@somewhere.org> <86r4a2vqbu.fsf@somewhere.org> <867gbqdisp.fsf@somewhere.org> <83haas5y88.fsf@gnu.org> <529C64C5.2040509@yandex.ru> <834n6r5edh.fsf@gnu.org> <529DAAED.9000504@yandex.ru> <83ob4y3wi5.fsf@gnu.org> <529DF416.7070807@yandex.ru> <83txeo33ls.fsf@gnu.org> <52A01D59.7030304@yandex.ru> <83lhzz2oal.fsf@gnu.org> <52A80BA8.3050403@yandex.ru> <83ob4nwdw0.fsf@gnu.org> <52A8A850.8040302@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1386786129 13183 80.91.229.3 (11 Dec 2013 18:22:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Dec 2013 18:22:09 +0000 (UTC) Cc: sva-news@mygooglest.com, 15876@debbugs.gnu.org To: Dmitry Antipov , Kenichi Handa , Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 11 19:22:13 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VqoQH-0001to-0z for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Dec 2013 19:22:13 +0100 Original-Received: from localhost ([::1]:59248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqoQG-0000ev-JO for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Dec 2013 13:22:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqoHT-0005IW-To for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2013 13:13:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqoHO-0003Jg-Tz for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2013 13:13:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqoHO-0003Ja-RB for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2013 13:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VqoHO-0006Rk-4a for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2013 13:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2013 18:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15876 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15876-submit@debbugs.gnu.org id=B15876.138678553724726 (code B ref 15876); Wed, 11 Dec 2013 18:13:02 +0000 Original-Received: (at 15876) by debbugs.gnu.org; 11 Dec 2013 18:12:17 +0000 Original-Received: from localhost ([127.0.0.1]:44190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqoGf-0006Qk-7O for submit@debbugs.gnu.org; Wed, 11 Dec 2013 13:12:17 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:42729) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqoGb-0006QW-46 for 15876@debbugs.gnu.org; Wed, 11 Dec 2013 13:12:14 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MXN00G00MBJ2800@a-mtaout22.012.net.il> for 15876@debbugs.gnu.org; Wed, 11 Dec 2013 20:12:11 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MXN00FSFMKAUR80@a-mtaout22.012.net.il>; Wed, 11 Dec 2013 20:12:11 +0200 (IST) In-reply-to: <52A8A850.8040302@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81776 Archived-At: > Date: Wed, 11 Dec 2013 22:00:48 +0400 > From: Dmitry Antipov > CC: 15876@debbugs.gnu.org, sva-news@mygooglest.com > > > Anyway, what about the patch below? With it, the problem disappears > > even without your "threshold" based GC. > > Looks good. But can we assume that FACE_FROM_ID (...) is always non-NULL? > Some important routines, like mark_face_cache, do not rely on this. I think you are right, and we should make sure it's non-NULL before dereferencing. Jan, Ken'ichi, would you please comment on this? Are we losing something by reusing already loaded fonts that support a given character, as opposed to looking for the "best-match" font?