From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Linux, non-DOS_NT platforms. Date: Thu, 25 Sep 2014 19:48:07 +0300 Message-ID: <83k34rve7s.fsf@gnu.org> References: <837g0sw1yx.fsf@gnu.org> <54243D92.8080005@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1411663716 11890 80.91.229.3 (25 Sep 2014 16:48:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Sep 2014 16:48:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 25 18:48:29 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XXCDU-0002Gm-Jm for ged-emacs-devel@m.gmane.org; Thu, 25 Sep 2014 18:48:28 +0200 Original-Received: from localhost ([::1]:41276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXCDU-000510-9a for ged-emacs-devel@m.gmane.org; Thu, 25 Sep 2014 12:48:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXCDM-00050o-Ex for emacs-devel@gnu.org; Thu, 25 Sep 2014 12:48:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXCDH-0003Sp-93 for emacs-devel@gnu.org; Thu, 25 Sep 2014 12:48:20 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:42945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXCDH-0003Rf-0N for emacs-devel@gnu.org; Thu, 25 Sep 2014 12:48:15 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NCG00000UBLBL00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 25 Sep 2014 19:48:08 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCG000RZUO8C300@a-mtaout22.012.net.il>; Thu, 25 Sep 2014 19:48:08 +0300 (IDT) In-reply-to: <54243D92.8080005@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174709 Archived-At: > Date: Thu, 25 Sep 2014 09:06:42 -0700 > From: Paul Eggert > CC: emacs-devel@gnu.org > > Eli Zaretskii wrote: > > I don't understand these sneaky practices, and I wish they'd > > stopped. How many times do you have to be told to revert your commits > > before you understand that this is not how we do things around here? > > The issue was briefly discussed, there were problems with MS-Windows > that I do not follow and cannot easily test, Dmitry played it safe and > left MS-Windows alone, and I followed his lead. It was reasonable for > us to be cautious about enabling USE_STACK_LISP_OBJECTS on an untested > and potentially-problematic platform. And it was reasonable for you to > enable USE_STACK_LISP_OBJECTS on MS-Windows once you installed further > changes to fix the problems and had tested the result. The point is that whether to turn this on by default and for which platforms was never discussed. Dmitry asked for help in testing that on Windows, and I provided my conclusions about that. Another user reported problems with clang. That's it; no further discussions were conducted. What you say above does not (and cannot) refute this basic fact. This is not how this should be done. We should discuss first, arrive at some conclusion, and only then act. This is a team project, and no single one of us can hope to grasp all the effects and consequences of any serious changes such as this one. > the above-quoted remarks are unwarranted. On the contrary, they were well deserved. > By the way, I share Stefan's concern that the performance improvements > of USE_STACK_LISP_OBJECTS haven't been adequately demonstrated. So do I, but that's another issue, unrelated to what I protested about.