From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Linux, non-DOS_NT platforms.
Date: Thu, 25 Sep 2014 19:48:07 +0300 [thread overview]
Message-ID: <83k34rve7s.fsf@gnu.org> (raw)
In-Reply-To: <54243D92.8080005@cs.ucla.edu>
> Date: Thu, 25 Sep 2014 09:06:42 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: emacs-devel@gnu.org
>
> Eli Zaretskii wrote:
> > I don't understand these sneaky practices, and I wish they'd
> > stopped. How many times do you have to be told to revert your commits
> > before you understand that this is not how we do things around here?
>
> The issue was briefly discussed, there were problems with MS-Windows
> that I do not follow and cannot easily test, Dmitry played it safe and
> left MS-Windows alone, and I followed his lead. It was reasonable for
> us to be cautious about enabling USE_STACK_LISP_OBJECTS on an untested
> and potentially-problematic platform. And it was reasonable for you to
> enable USE_STACK_LISP_OBJECTS on MS-Windows once you installed further
> changes to fix the problems and had tested the result.
The point is that whether to turn this on by default and for which
platforms was never discussed. Dmitry asked for help in testing that
on Windows, and I provided my conclusions about that. Another user
reported problems with clang. That's it; no further discussions were
conducted. What you say above does not (and cannot) refute this basic
fact.
This is not how this should be done. We should discuss first, arrive
at some conclusion, and only then act. This is a team project, and no
single one of us can hope to grasp all the effects and consequences of
any serious changes such as this one.
> the above-quoted remarks are unwarranted.
On the contrary, they were well deserved.
> By the way, I share Stefan's concern that the performance improvements
> of USE_STACK_LISP_OBJECTS haven't been adequately demonstrated.
So do I, but that's another issue, unrelated to what I protested
about.
next prev parent reply other threads:[~2014-09-25 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 8:15 [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Linux, non-DOS_NT platforms Eli Zaretskii
2014-09-25 9:51 ` Dmitry Antipov
2014-09-25 10:14 ` Eli Zaretskii
2014-09-25 12:52 ` Stefan Monnier
2014-09-25 16:12 ` Dmitry Antipov
2014-09-25 18:12 ` Stefan Monnier
2014-09-25 19:08 ` Paul Eggert
2014-09-25 9:52 ` Eli Zaretskii
2014-09-25 16:06 ` Paul Eggert
2014-09-25 16:48 ` Eli Zaretskii [this message]
2014-09-25 18:46 ` Paul Eggert
2014-09-25 19:16 ` Eli Zaretskii
2014-09-25 20:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k34rve7s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.