From: Eli Zaretskii <eliz@gnu.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: dmantipov@yandex.ru, emacs-devel@gnu.org
Subject: Re: Bidi reordering engine upgraded
Date: Sat, 18 Oct 2014 15:54:15 +0300 [thread overview]
Message-ID: <83k33xedxk.fsf@gnu.org> (raw)
In-Reply-To: <29ADC056-D9F9-461C-9D2E-D7F4AC5EE72F@swipnet.se>
> From: Jan Djärv <jan.h.d@swipnet.se>
> Date: Sat, 18 Oct 2014 14:34:06 +0200
> Cc: dmantipov@yandex.ru,
> emacs-devel@gnu.org
>
> > /* Compute frame-relative coordinates for phys cursor. */
> > get_phys_cursor_geometry (w, row, cursor_glyph, &x, &y, &h);
> > - wd = w->phys_cursor_width;
> > + wd = w->phys_cursor_width - 1;
>
> Are we sure this never becomes negative?
If it does, we already have that problem, since previously, the
subtraction of 1 was done in get_phys_cursor_geometry.
> I suggest you check it in so we can test it.
OK, will do.
> Do we have a test case?
Yes, the one posted by Dmitry here:
http://lists.gnu.org/archive/html/emacs-devel/2014-10/msg00518.html
next prev parent reply other threads:[~2014-10-18 12:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 14:51 Bidi reordering engine upgraded Eli Zaretskii
2014-10-15 15:22 ` Dmitry Antipov
2014-10-15 15:47 ` Eli Zaretskii
2014-10-15 16:00 ` Dmitry Antipov
2014-10-15 16:31 ` Eli Zaretskii
2014-10-15 17:28 ` Eli Zaretskii
2014-10-15 17:50 ` Eli Zaretskii
2014-10-16 3:55 ` Dmitry Antipov
2014-10-16 7:21 ` Eli Zaretskii
2014-10-16 9:42 ` Thien-Thi Nguyen
2014-10-16 10:15 ` Eli Zaretskii
2014-10-16 13:27 ` Thien-Thi Nguyen
2014-10-16 13:51 ` Eli Zaretskii
2014-10-17 5:42 ` Thien-Thi Nguyen
2014-10-17 6:16 ` Eli Zaretskii
2014-10-17 7:50 ` Thien-Thi Nguyen
2014-10-17 8:25 ` Eli Zaretskii
2014-10-17 10:27 ` Thien-Thi Nguyen
2014-10-17 10:31 ` Eli Zaretskii
2014-10-16 9:51 ` Dmitry Antipov
2014-10-16 10:20 ` Eli Zaretskii
2014-10-16 11:28 ` Eli Zaretskii
2014-10-17 6:46 ` Eli Zaretskii
2014-10-17 17:45 ` Jan Djärv
2014-10-17 18:45 ` Eli Zaretskii
2014-10-17 19:32 ` Stefan Monnier
2014-10-18 12:34 ` Jan Djärv
2014-10-18 12:54 ` Eli Zaretskii [this message]
2014-10-18 13:13 ` Eli Zaretskii
2014-10-19 11:45 ` Jan Djärv
2014-10-19 13:19 ` Eli Zaretskii
2014-10-19 11:49 ` Jan Djärv
2014-10-19 13:20 ` Eli Zaretskii
2014-10-20 19:17 ` bug#18778: noticeable slowdown for buffers with long lines, word-wrap, and brackets Ivan Shmakov
2014-10-20 19:33 ` Eli Zaretskii
2014-10-20 19:51 ` Ivan Shmakov
2014-10-22 16:12 ` Eli Zaretskii
2014-10-22 17:07 ` Ivan Shmakov
2014-10-29 19:31 ` Ivan Shmakov
-- strict thread matches above, loose matches on Subject: below --
2014-10-17 11:12 Bidi reordering engine upgraded grischka
2014-10-17 11:42 ` martin rudalics
2014-10-17 11:47 ` David Kastrup
2014-10-17 13:21 ` grischka
2014-10-17 13:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k33xedxk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.