From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Your commit 7409a79 Date: Sun, 07 Dec 2014 05:52:27 +0200 Message-ID: <83k324yv44.fsf@gnu.org> References: <83h9x917il.fsf@gnu.org> <85k324h0hg.fsf@stephe-leake.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1417924390 1934 80.91.229.3 (7 Dec 2014 03:53:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Dec 2014 03:53:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 07 04:53:05 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XxSu9-0002B1-CG for ged-emacs-devel@m.gmane.org; Sun, 07 Dec 2014 04:53:05 +0100 Original-Received: from localhost ([::1]:56332 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxSu9-0006VM-1v for ged-emacs-devel@m.gmane.org; Sat, 06 Dec 2014 22:53:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxStr-0006V5-IN for emacs-devel@gnu.org; Sat, 06 Dec 2014 22:52:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XxStm-0007Dj-79 for emacs-devel@gnu.org; Sat, 06 Dec 2014 22:52:47 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:34026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxStl-0007Df-UQ for emacs-devel@gnu.org; Sat, 06 Dec 2014 22:52:42 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NG7005001083U00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sun, 07 Dec 2014 05:52:40 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NG70042E1FRAW90@a-mtaout22.012.net.il>; Sun, 07 Dec 2014 05:52:40 +0200 (IST) In-reply-to: <85k324h0hg.fsf@stephe-leake.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179232 Archived-At: > From: Stephen Leake > Date: Sat, 06 Dec 2014 16:33:47 -0600 > > Eli Zaretskii writes: > > > commit 7409a79b1b2acf1229dd763f5eb7b96abc17113a > > Author: Stephen Leake > > Date: Fri Dec 5 13:13:55 2014 -0600 > > > > preparing for further changes/cleanup to developers/contributors docs > > > > * etc/CONTRIBUTE: renamed to ./CONTRIBUTE, > > > > Please always start the commit log summary line with a capital letter, > > and end the sentence with a period. > > Do we really need to be so picky? It's just a good style. > Note that the Gnu coding standard does _not_ discuss this level of > detail, although all the examples do have capitals and periods > (http://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs). Exactly. Also, all the other entries in Emacs's own logs. > I see this pickiness as a mild barrier to contributing I don't think it is. Writing correct English is a basic requirement, it doesn't even have to be in the document. Like correct spelling, for example. > > (Actually, in the above > > particular case the summary line is redundant and could be omitted -- > > but this is a stylistic comment, not a requirement.) > > I tried that: > > * etc/CONTRIBUTE: renamed to ./CONTRIBUTE, preparing for further changes/cleanup to developers/contributors docs The "preparing for" part doesn't need to be there, it has exactly zero importance in the context of a commit log. > I didn't want to just do: > > * etc/CONTRIBUTE: renamed to ./CONTRIBUTE > > since that doesn't say anything about _why_. You don't need to say why. You could push all the changes to the file, including its move, as a single commit, or a merge-commit with a single explanatory line. In general, keeping related changes together requires less explanations. You could also point to the list discussion, if you really think people will need to know why you moved the file. Also, saying it's "in preparation" of something doesn't really explain why, since a file can be changed without moving it.