From: Eli Zaretskii <eliz@gnu.org>
To: Rich Felker <dalias@libc.org>
Cc: emacs-devel@gnu.org
Subject: Re: Dumper issue, revisited; invalid realloc/free
Date: Wed, 04 Feb 2015 21:44:17 +0200 [thread overview]
Message-ID: <83k2zxfomm.fsf@gnu.org> (raw)
In-Reply-To: <20150204193732.GZ23507@brightrain.aerifal.cx>
> Date: Wed, 4 Feb 2015 14:37:32 -0500
> From: Rich Felker <dalias@libc.org>
> Cc: emacs-devel@gnu.org
>
> > > http://www.openwall.com/lists/musl/2015/02/03/1
> >
> > I suggest that you take a look at src/w32heap.c on Emacs's master
> > branch. There' you will see a simple solution of a very similar (if
> > not identical) problem we have on MS-Windows. It even includes a
> > simple handling of large allocations.
>
> As I suspected, this code is used only if you use gmalloc.c. It's not
> used with system_malloc=yes, which is the case I'm concerned about.
No, you are mistaken. The 'master' version of Emacs uses the system
malloc on MS-Windows. Perhaps you are looking at the 'emacs-24'
branch, where indeed we use gmalloc.c and ralloc.c, with sbrk
emulation in w32heap.c. But that's not what I had in mind.
> > Or that the libc memory allocation routines can gracefully handle
> > these situations.
>
> I would not consider that "graceful". If they detect that the pointer
> passed to realloc or free is invalid, the only reasonable behavior is
> to abort.
They could do exactly what you planned to do: ignore the 'free' part
and only allocate a new block.
next prev parent reply other threads:[~2015-02-04 19:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 17:57 Dumper issue, revisited; invalid realloc/free Rich Felker
2015-02-04 19:08 ` Eli Zaretskii
2015-02-04 19:13 ` Rich Felker
2015-02-04 19:22 ` Eli Zaretskii
2015-02-04 19:26 ` Eli Zaretskii
2015-02-04 20:34 ` Ken Brown
2015-02-05 1:31 ` Rich Felker
2015-02-05 3:25 ` Rich Felker
2015-02-05 3:48 ` Eli Zaretskii
2015-02-05 4:33 ` Rich Felker
2015-02-05 16:14 ` Wolfgang Jenkner
2015-02-05 18:43 ` Rich Felker
2015-02-04 19:21 ` Eli Zaretskii
2015-02-04 19:37 ` Rich Felker
2015-02-04 19:44 ` Eli Zaretskii [this message]
2015-02-04 19:49 ` Rich Felker
2015-02-04 19:54 ` Eli Zaretskii
2015-02-04 20:02 ` Rich Felker
2015-02-04 20:36 ` Eli Zaretskii
2015-02-04 20:08 ` Rich Felker
2015-02-04 20:40 ` Eli Zaretskii
2015-02-04 22:17 ` Rich Felker
2015-02-05 3:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k2zxfomm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dalias@libc.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.