all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Fujii Hironori <fujii.hironori@gmail.com>
Cc: 11732@debbugs.gnu.org
Subject: bug#11732: 24.1; Microsoft IME Japanese input problem
Date: Thu, 19 Feb 2015 08:44:01 +0200	[thread overview]
Message-ID: <83k2ze4czy.fsf@gnu.org> (raw)
In-Reply-To: <CALus1PnuvdqHNha7gw0+mHiGGMjE+T14pXMtZ8s=7mAGkuiRbQ@mail.gmail.com>

> Date: Thu, 19 Feb 2015 11:03:58 +0900
> From: Fujii Hironori <fujii.hironori@gmail.com>
> Cc: 11732@debbugs.gnu.org
> 
> >>         set_ime_composition_window_fn (context, &form);
> >>         release_ime_context_fn (hwnd, context);
> >>       }
> >> -      break;
> >> +      goto dflt;
> >>
> >>      case WM_IME_ENDCOMPOSITION:
> >>        ignore_ime_char = 0;
> >
> > Passes the message to DefWindowProc even if we succeeded to handle
> > WM_IME_STARTCOMPOSITION by calling ImmSetCompositionWindow.  Why is
> > that needed?
> 
> If Emacs processes WM_IME_STARTCOMPOSITION itself,
> default composition window won't be shown.
> 
> Please see the document for the detail.
> 
> https://msdn.microsoft.com/en-us/library/windows/desktop/dd374143%28v=vs.85%29.aspx
> 
> | Remarks
> |
> | This message is a notification to an IME window to open its
> | composition window. An application should process this message if it
> | displays composition characters itself.
> |
> | If an application has created an IME window, it should pass this
> | message to that window. The DefWindowProc function processes the
> | message by passing it to the default IME window.

Yes, I've read that, but it's still not clear to me what that mean in
practice.  Are you saying that ImmSetCompositionWindow only sets the
position of the composition window, but it will not be shown unless we
pass WM_IME_STARTCOMPOSITION to DefWindowProc?  In that case, how will
Windows know that the composition window we positioned is "the default
IME window"?

Or are you saying we should be calling ImmSetCompositionWindow at all?
That call was introduced as result of solving bugs #2570 and #2569, so
I think the call or its equivalent should stay.

Sorry I'm asking all these questions, but I don't know enough about
IME programming, and need to understand this in order to see that the
patch doesn't break anything else.

Thanks.





  reply	other threads:[~2015-02-19  6:44 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18  5:20 bug#11732: 24.1; Microsoft IME Japanese input problem xavier.dahan
2015-02-17 10:26 ` Fujii Hironori
2015-02-18 15:17   ` Eli Zaretskii
2015-02-19  2:03     ` Fujii Hironori
2015-02-19  6:44       ` Eli Zaretskii [this message]
     [not found]         ` <CALus1PmqiC8TnQTfcpVFD5ObjqbK_4hkOczRKmG1=+mkWXUHWQ@mail.gmail.com>
2015-02-19 11:44           ` Eli Zaretskii
2015-03-06 20:29             ` Eli Zaretskii
2015-03-06 22:37               ` Fujii Hironori
2015-03-07 10:53                 ` Eli Zaretskii
2015-03-09  2:13               ` Fujii Hironori
2015-03-09 16:30                 ` Eli Zaretskii
2018-06-26  9:10 ` bug#11732: Follow-up to bug#11732 Masayuki Hatta
2018-06-27 15:54   ` Eli Zaretskii
2018-06-28  8:04     ` martin rudalics
2018-06-28 10:13       ` Masayuki Hatta
2018-06-28 12:25         ` martin rudalics
2018-06-28 13:09           ` Eli Zaretskii
2018-06-28 10:11     ` Masayuki Hatta
2018-06-28 13:28       ` Eli Zaretskii
2018-06-28 19:17         ` Noam Postavsky
2018-06-28 19:24           ` Eli Zaretskii
2018-06-29  7:39             ` Masayuki Hatta
2018-06-29  8:43               ` martin rudalics
2018-06-29  8:59                 ` Eli Zaretskii
2018-06-30  3:14                 ` Masayuki Hatta
2018-06-30  7:46                   ` Eli Zaretskii
2018-06-30  8:30                     ` Masayuki Hatta
2018-06-29  8:56               ` Eli Zaretskii
2018-06-29  8:43     ` martin rudalics
2018-06-29  9:07       ` Eli Zaretskii
2018-06-30  8:06         ` martin rudalics
2018-06-30 11:32           ` Eli Zaretskii
2018-06-30 12:51             ` martin rudalics
2018-06-30 13:21               ` Eli Zaretskii
2018-07-01  9:00                 ` martin rudalics
2018-07-01 14:29                   ` Eli Zaretskii
2018-07-03  8:29                     ` martin rudalics
2018-07-03 18:50                       ` Eli Zaretskii
2018-07-07  7:45                         ` Tak Kunihiro
2018-07-07 10:00                           ` Eli Zaretskii
2018-07-07 10:21                             ` martin rudalics
2018-07-07 11:32                               ` Eli Zaretskii
2018-07-01 14:34             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k2ze4czy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=11732@debbugs.gnu.org \
    --cc=fujii.hironori@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.