From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20701: 25.0.50; [PATCH] (vertical-motion 0) broken at display strings after newline Date: Sun, 31 May 2015 18:08:20 +0300 Message-ID: <83k2vou6mz.fsf@gnu.org> References: <85y4k47qf6.fsf@iznogoud.viz> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1433084971 28907 80.91.229.3 (31 May 2015 15:09:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 May 2015 15:09:31 +0000 (UTC) Cc: 20701@debbugs.gnu.org To: Wolfgang Jenkner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 31 17:09:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yz4rQ-00028c-An for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 May 2015 17:09:12 +0200 Original-Received: from localhost ([::1]:42288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yz4rP-0006aN-IM for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 May 2015 11:09:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yz4rL-0006ZH-TU for bug-gnu-emacs@gnu.org; Sun, 31 May 2015 11:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yz4rI-0008MC-I2 for bug-gnu-emacs@gnu.org; Sun, 31 May 2015 11:09:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yz4rI-0008Lz-E7 for bug-gnu-emacs@gnu.org; Sun, 31 May 2015 11:09:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yz4rI-0006x1-0o for bug-gnu-emacs@gnu.org; Sun, 31 May 2015 11:09:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 May 2015 15:09:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20701-submit@debbugs.gnu.org id=B20701.143308492126673 (code B ref 20701); Sun, 31 May 2015 15:09:03 +0000 Original-Received: (at 20701) by debbugs.gnu.org; 31 May 2015 15:08:41 +0000 Original-Received: from localhost ([127.0.0.1]:35033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yz4qu-0006w8-EQ for submit@debbugs.gnu.org; Sun, 31 May 2015 11:08:41 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:46359) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yz4qq-0006vs-VE for 20701@debbugs.gnu.org; Sun, 31 May 2015 11:08:38 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NP700A00YNZCW00@mtaout24.012.net.il> for 20701@debbugs.gnu.org; Sun, 31 May 2015 18:00:05 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NP7003FKZ04DI80@mtaout24.012.net.il>; Sun, 31 May 2015 18:00:05 +0300 (IDT) In-reply-to: <85y4k47qf6.fsf@iznogoud.viz> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103398 Archived-At: > Cc: Eli Zaretskii > From: Wolfgang Jenkner > Date: Sun, 31 May 2015 16:19:46 +0200 > > If you run the following snippet in emacs -Q point will end up at the > first line of the "Test" buffer, but it should stay at the second line. > > (with-current-buffer (generate-new-buffer "Test") > (pop-to-buffer (current-buffer)) > (insert "x\n") > (save-excursion > (insert (propertize "x" 'display "x"))) > (sit-for 1) > (vertical-motion 0)) > > On the other hand, non-zero arguments for vertical-motion seem to work > correctly, as long as the buffer contains only ASCII characters before > the propertized "x". > > Otherwise > > (with-current-buffer (generate-new-buffer "Test") > (pop-to-buffer (current-buffer)) > (insert "\né\n") > (save-excursion > (insert (propertize "x" 'display "x"))) > (sit-for 1) > (vertical-motion -1)) > > Here, point should go to the second line but it goes to the first line. > > The following patch tries to fix both issues. > > -- >8 -- > Subject: [PATCH] * src/indent.c (Fvertical_motion): Fix a case of motion by 0 > lines. > > Starting from a display string after a newline, point went to the > previous line. > > Also, correct an inadvertent use of a buffer position with FETCH_BYTE. Looks good to me, please push. Thanks.