all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Explicit encoding cookie in Elisp files Add prettify-symbols-alist for js-mode
Date: Mon, 28 Sep 2015 11:24:33 +0300	[thread overview]
Message-ID: <83k2rbdk8u.fsf@gnu.org> (raw)
In-Reply-To: <5608F1FC.8090904@yandex.ru>

> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 28 Sep 2015 10:53:32 +0300
> 
> > And the [need to visit Emacs files with older Emacs versions]
> > happens, at least to me, quite a lot, e.g. when I need to look at
> > those files on a system where only an older Emacs is installed or
> > usable.
> 
> Hopefully, that will occur less and less. 24.4 will soon be a year old.

Of course.  But I still routinely work on systems where 23.2 is the
latest installed version, and I'm a simple user there, so I cannot
upgrade that.

> > Did you see how many of our Lisp files already have the cookie that
> > states UTF-8 encoding?  (Answer: 197.)  Moreover, various features
> > that generate *.el files automatically insert the cookie there, see
> > autoload.el and ido.el for just 2 examples.  Did this bother you, or
> > anyone else, until now?
> 
> I wasn't actively aware of that, but I imagine a lot of them come from 
> before Emacs 24.4 (both files and generation scripts).
> 
> If it's inconsistency you dislike, I can commit to spend the effort and 
> remove the cookies where they're not strictly required, if you like.

I did what I did semi-automatically because we were doing that for
years.  I didn't even remember that we default to UTF-8 in *.el files
until Stefan reminded me.  Why? because we never bothered to remove
the cookies after we made that change, nor stop producing them in
auto-generated *.el files.

Inconsistency?  Yes, I dislike it, but I dislike discrimination and
lack of fair play even more.

> > So why did that single commit, which added a
> > cookie to 3 more files, for a 1.5% growth, suddenly bother you?  I
> > just did what we have been doing for many years, something that was
> > burned into my muscle memory during all those years.
> 
> Imagine that we added a new syntax feature to Elisp, used it for over a 
> year from time to time in some new code, and them one of the developers 
> "desugared" all its uses into more verbose code that's compatible with 
> older Emacsen. The present situation is not as absurd, but that's the 
> direction I'm looking at it from.

Once again, you are blowing out of proportion a minor issue.  It lacks
any potential for any kind of grave consequences, so far-fetched
absurd analogies are inappropriate here.  One more reason for me to
suspect the issue itself is not what made you so worked up.

> > IOW, don't you see how this minuscule issue is blown out of
> > proportions for reasons I cannot even begin to understand?  And why do
> > you single out only those 3 files, but say nothing about the others?
> > If you really dislike those cookies so much, I'd expect you to first
> > realize the magnitude of the "problem", and then attack it
> > consistently across the board, rather than pouncing on my single
> > commit.
> 
> We also have lots of compilation warnings, non-idiomatic (or just 
> somewhat obsolete) uses of Elisp in different places, and other similar 
> problems, for which there's not enough manpower/enthusiasm to fix.

Judging by the energy invested in this discussion, I don't think we
should lack manpower/enthusiasm to fix the issue consistently, only
redirect it.  Assuming, that is, that the issue is indeed the cookies
themselves.

> But like I said, my issue is not with individual cookies

Then why did you want to revert db828f6?

> but with the strong suggestion to add them everywhere UTF-8 is used.

The text in CONTRIBUTE is hardly a "strong" suggestion.



  reply	other threads:[~2015-09-28  8:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-26 11:49 bug#21568: [PATCH] Add prettify-symbols-alist for js-mode Simen Heggestøyl
2015-09-26 13:32 ` Eli Zaretskii
2015-09-26 15:59   ` Simen Heggestøyl
2015-09-27  0:39     ` Xue Fuqiao
2015-09-27  2:01       ` Dmitry Gutov
2015-09-27  6:04         ` Eli Zaretskii
2015-09-27  6:12           ` Dmitry Gutov
2015-09-27  7:28             ` Eli Zaretskii
2015-09-27  8:21               ` Dmitry Gutov
2015-09-27  8:39                 ` Eli Zaretskii
2015-09-27  8:50                   ` Dmitry Gutov
2015-09-27 10:03                     ` Eli Zaretskii
2015-09-27 14:11                       ` Dmitry Gutov
2015-09-27 18:37                         ` Eli Zaretskii
2015-09-27 19:13                           ` Dmitry Gutov
2015-09-27 19:46                             ` Eli Zaretskii
2015-09-27 20:18                               ` Dmitry Gutov
2015-09-27 21:01                                 ` Eli Zaretskii
2015-09-28  4:16                                   ` Explicit encoding cookie in Elisp files, was: " Dmitry Gutov
2015-09-28  7:27                                     ` Explicit encoding cookie in Elisp files " Eli Zaretskii
2015-09-28  7:53                                       ` Dmitry Gutov
2015-09-28  8:24                                         ` Eli Zaretskii [this message]
2015-09-28 22:54                                           ` Dmitry Gutov
2015-09-27  8:10             ` bug#21568: [PATCH] " Simen Heggestøyl
2015-09-27 14:28         ` Xue Fuqiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k2rbdk8u.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.