From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 8ba156f: Attempt to avoid crashes in plist-member
Date: Tue, 13 Oct 2015 05:42:47 +0300 [thread overview]
Message-ID: <83k2qro5eg.fsf@gnu.org> (raw)
In-Reply-To: <jwvoag360ib.fsf-monnier+emacsdiffs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 12 Oct 2015 21:07:00 -0400
>
> > Attempt to avoid crashes in plist-member
>
> > * src/fns.c (Fplist_member): Don't call QUIT between a CONSP test
> > and a call to XCDR. (Bug#21655)
>
> I have no objection to the patch itself, but I must say that I wonder
> how it can avoid crashes. IOW why would calling QUIT between a CONSP test
> and a call to XCDR be dangerous?
QUIT could call some Lisp.
How else would you explain a segfault in that loop?
next prev parent reply other threads:[~2015-10-13 2:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151012170324.17966.77@vcs.savannah.gnu.org>
[not found] ` <E1ZlgVQ-0004gO-Em@vcs.savannah.gnu.org>
2015-10-13 1:07 ` [Emacs-diffs] master 8ba156f: Attempt to avoid crashes in plist-member Stefan Monnier
2015-10-13 2:42 ` Eli Zaretskii [this message]
2015-10-13 3:36 ` Paul Eggert
2015-10-13 14:58 ` Eli Zaretskii
2015-10-13 15:08 ` David Kastrup
2015-10-13 15:32 ` Eli Zaretskii
2015-10-13 15:50 ` David Kastrup
2015-10-13 15:21 ` Paul Eggert
2015-10-13 15:34 ` Eli Zaretskii
2015-10-13 19:05 ` Stefan Monnier
2015-10-13 8:00 ` Andreas Schwab
2015-10-13 15:01 ` Eli Zaretskii
2015-10-13 10:26 ` David Kastrup
2015-10-13 13:23 ` Stefan Monnier
2015-10-13 13:41 ` David Kastrup
2015-10-13 15:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k2qro5eg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.