From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Contributors and maintainers Date: Wed, 21 Oct 2015 20:41:19 +0300 Message-ID: <83k2qgunk0.fsf@gnu.org> References: <87si59wj42.fsf@T420.taylan> <871tcr7yvq.fsf@fastmail.com> <87mvvfm0bd.fsf@T420.taylan> <56250803.5080601@cs.ucla.edu> <87a8ren5ys.fsf@T420.taylan> <56259BB1.3070908@cs.ucla.edu> <878u6ykmvt.fsf@T420.taylan> <87h9llvo98.fsf@members.fsf.org> <5626622A.3090707@yandex.ru> <87zizdijbp.fsf@T420.taylan> <56267302.7050606@yandex.ru> <87io61igyu.fsf@T420.taylan> <56267CDF.6010201@yandex.ru> <87wpuhh15s.fsf@T420.taylan> <562683B9.1060305@yandex.ru> <83y4exe71v.fsf@gnu.org> <87zizcfzna.fsf@T420.taylan> <83r3koe2nj.fsf@gnu.org> <874mhkffvr.fsf@T420.taylan> <83y4ewur5b.fsf@gnu.org> <87r3kodtml.fsf@T420.taylan> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1445449326 14327 80.91.229.3 (21 Oct 2015 17:42:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Oct 2015 17:42:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1=2FK?= =?utf-8?Q?ammer?=) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 21 19:41:53 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZoxOV-0003BV-RL for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 19:41:48 +0200 Original-Received: from localhost ([::1]:53086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoxOQ-0000lH-VI for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 13:41:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoxOA-0000l6-8w for emacs-devel@gnu.org; Wed, 21 Oct 2015 13:41:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoxO7-00025M-0A for emacs-devel@gnu.org; Wed, 21 Oct 2015 13:41:26 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:44668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoxO6-00024m-Ia for emacs-devel@gnu.org; Wed, 21 Oct 2015 13:41:22 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NWK00700ZLXOB00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Wed, 21 Oct 2015 20:41:20 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWK007OIZSVMN20@a-mtaout20.012.net.il>; Wed, 21 Oct 2015 20:41:20 +0300 (IDT) In-reply-to: <87r3kodtml.fsf@T420.taylan> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192305 Archived-At: > From: taylanbayirli@gmail.com (Taylan Ulrich Bay=C4=B1rl=C4=B1/Kamm= er) > Cc: emacs-devel@gnu.org > Date: Wed, 21 Oct 2015 19:22:10 +0200 >=20 > >> Can you please show a previous quote by you which serves to show= that > >> you understood the reason I did not want to use shell-quote-argu= ment, > >> and where you directly addressed that exact reason (either with = a change > >> to shell-quote-argument, *or* an explanation of why you disagree= with > >> that exact reason)? > > > > Everything I wrote serves to show that. I always responded to yo= ur > > arguments. > > > >> When you show such a quote, then maybe we can look at it and see= how it > >> could be that you feel my concern has been addressed, yet I don'= t. > > > > Not only I feel that your concerns has been addressed, everyone e= lse > > here does. >=20 > It would be great if you could provide a quote like I mentioned. OK. Here are some: Quote #1: > > On POSIX shells, shell-quote-argument is just as safe as > > shqq--quote-string, and on non-POSIX shells it works better. So= it's a > > win, in both readability and in portability, to use > > shell-quote-argument. >=20 > Fixing it does not seem easy at all given I can't trust > shell-quote-argument. You can trust it. > And please be realistic in the amount of trust we can put on the > complicated implementations for non-Unix shells. I can't judge t= hem > myself since I don't know the syntax of those shells at all. Doe= s > anyone here know their syntax comprehensively, or checked the > implementation against the documentation of those shells? Yes, we do. Yes, we have. Quote #2: > > It might be simpler, but it's wrong, because the result is only > > correct for Posix shells. > > > > Please do use shell-quote-argument instead. >=20 > It's also simpler than the POSIX section of shell-quote-argument. Simpler doesn't mean correct. > (defun shell-quote-argument (argument) > [...] (cond [...] (t > (if (equal argument "") > "''" > ;; Quote everything except POSIX filename characters. > ;; This should be safe enough even for really weird shells. > (replace-regexp-in-string > "\n" "'\n'" > (replace-regexp-in-string "[^-0-9a-zA-Z_./\n]" "\\\\\\&" a= rgument)))))) >=20 > I wonder what "really weird shells" this refers to? The set of characters special to an arbitrary shell is not known in advance. > Certainly not csh, the mechanism it uses for newlines doesn't wor= k > there. What did you try that didn't work with csh? Quote #3: > Quoting RMS, coincidentally from a couple days ago: >=20 > The policy is non-GNU systems are secondary, and lower priori= ty than > the GNU system, but we are glad to include support for them i= n GNU > packages if users contribute the necessary code -- provided t= hat > code isn't a maintenance problem for us. >=20 > The maintenainers of any particular package are the ones who = judge > whether that code is a maintenance problem, since they are th= e ones > it would be a problem for. I don't see how this is relevant for the issue at hand, since the necessary code (the shell-quote-argument function) was already contributed to Emacs years ago, and is used in many places in core Emacs. There's no extra effort needed to support more platforms, j= ust replace one function with another. > I generally don't want to take responsibility of my code being us= ed on > non-GNU/non-POSIX systems, but if I can share the responsibility = then > that's fine. You are sharing the responsibility with a long line of Emacs developers, all of whom use this function. I don't see anything yo= u should worry about, really. As you see, each response is directly related to your text that I cite. I cannot prove to you that I understood what you were saying, but you can ask any neutral person to read this and tell you what the= y think about that. From my side, I can assure you I completely understood everything that you said.