From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Sun, 01 Nov 2015 18:50:00 +0200 Message-ID: <83k2q1y893.fsf@gnu.org> References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> <20151031233225.GD1853@acm.fritz.box> <20151101135253.GB2768@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1446396623 3476 80.91.229.3 (1 Nov 2015 16:50:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Nov 2015 16:50:23 +0000 (UTC) Cc: bruce.connor.am@gmail.com, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 01 17:50:14 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZsvpZ-0004kV-6k for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 17:50:09 +0100 Original-Received: from localhost ([::1]:37963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsvpY-0000xx-BW for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 11:50:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsvpL-0000xn-HK for emacs-devel@gnu.org; Sun, 01 Nov 2015 11:49:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsvpI-0001MM-Aw for emacs-devel@gnu.org; Sun, 01 Nov 2015 11:49:55 -0500 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:49401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsvpH-0001M3-Ta for emacs-devel@gnu.org; Sun, 01 Nov 2015 11:49:52 -0500 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NX500700A5ZYP00@mtaout24.012.net.il> for emacs-devel@gnu.org; Sun, 01 Nov 2015 18:43:14 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NX5003GVAG1AW50@mtaout24.012.net.il>; Sun, 01 Nov 2015 18:43:14 +0200 (IST) In-reply-to: <20151101135253.GB2768@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193068 Archived-At: > Date: Sun, 1 Nov 2015 13:52:53 +0000 > From: Alan Mackenzie > Cc: emacs-devel > > No problem! The patch below doesn't actually apply at the moment, due > to some (?very) recent change in isearch.el. But it wouldn't run > anyway, because window*-start and friends aren't there yet. > > > > diff --git a/lisp/isearch.el b/lisp/isearch.el > index 4fc9b38..07ec534 100644 > --- a/lisp/isearch.el > +++ b/lisp/isearch.el How is this "not having isearch know about Follow mode"? I see that knowledge on every step of this patch, whenever you call the new functions. So maybe I'm missing something, but I really don't see why this variant is significantly better than the one Stefan didn't like. Can you explain what am I missing here? I thought you will come up with some more generic framework for commands to "scroll" the display by switching to the next window (when under Follow mode), if possible. But unless I'm missing something very important, this isn't that framework, is it? Btw, I see no reason to introduce new functions. Instead, we could have the original ones accept an additional optional argument. As yet another comment, wrt this exchange between you and John: > > What is the reason for having separate functions such as window*-start, > > instead of just taking the car of a list of windows? I may be missing some > > context here, but this sounds like special-casing general behavior, and I'm > > wondering why it's necessary... > [...] > The fact that the "group" of windows is represented by a list is an > implementation detail to be encapsulated within follow.el. In the > (fairly distant) future, this might perhaps be superseded by code in > redisplay. Perhaps. You are right about not relying on the list, but window-next-sibling and window-prev-sibling are available, and always will be, so you can "trivially" use them instead of relying on a list. If you agree, then John's question still stands, I think.