From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 25e461c 1/2: Fix visiting files with raw-text Date: Sun, 13 Dec 2015 22:46:24 +0200 Message-ID: <83k2oi3wm7.fsf@gnu.org> References: <20151213195208.12085.93274@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1450039594 16895 80.91.229.3 (13 Dec 2015 20:46:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Dec 2015 20:46:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 13 21:46:33 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8DXM-0007g5-O4 for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2015 21:46:32 +0100 Original-Received: from localhost ([::1]:56546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8DXL-00065B-MT for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2015 15:46:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8DX8-00064j-Fp for emacs-devel@gnu.org; Sun, 13 Dec 2015 15:46:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8DX5-0002rN-AZ for emacs-devel@gnu.org; Sun, 13 Dec 2015 15:46:18 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8DX5-0002r5-7H; Sun, 13 Dec 2015 15:46:15 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3719 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1a8DX4-0007f6-Dv; Sun, 13 Dec 2015 15:46:14 -0500 In-reply-to: (message from Stefan Monnier on Sun, 13 Dec 2015 15:25:33 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196220 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Sun, 13 Dec 2015 15:25:33 -0500 > > > - Fset_buffer_multibyte (Qnil); > > + if (inserted > 0) > > + bset_enable_multibyte_characters (current_buffer, Qnil); > > + else > > + Fset_buffer_multibyte (Qnil); > > Hmm... IIUC if (inserted > 0) we need bset_enable_multibyte_characters > because Fset_buffer_multibyte would try to convert the chars we > just inserted. > > And IIUC we recently switched to Fset_buffer_multibyte in order to > handle the case where the buffer was not empty when we started (in > which case we need to convert the content that was present before we > started insertion). > > So, IIUC if the buffer was not empty to start with *and* (inserted > 0), > then we have a problem because neither function is right. > > Or did I miss something? If inserted is positive, there's code after that which takes care of adjusting the buffer's gap etc. So it's only needed when nothing was inserted.