all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: dired and ls (was: Human-readable file sorting)
Date: Sat, 20 Feb 2016 11:57:40 +0200	[thread overview]
Message-ID: <83k2lzpuuj.fsf@gnu.org> (raw)
In-Reply-To: <87mvqvewk6.fsf_-_@gnus.org> (message from Lars Ingebrigtsen on Sat, 20 Feb 2016 17:16:09 +1100)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sat, 20 Feb 2016 17:16:09 +1100
> 
> This all reminds me of something I forgot to prattle on about in that
> dired bug report: ls-lisp.el.
> 
> dired (on Unixey systems) uses "ls" to get the contents of directories,
> and then parses the results.  And generates a buffer.  Not all systems
> have "ls", so in that case it uses ls-lisp.el, which just calls
> directory-files and then file-attributes in a loop.
> 
> I think this is rather suboptimal for many reasons:
> 
> 1) dired look unnecessarily different on different systems
> 
> 2) the customisability is limited -- both the look of the buffers and
> the sorting is limited by what the native "ls" returns
> 
> 3) Reasons!  So many reasons!
> 
> I've asked "but why" before, but the only response I can remember is "ls
> is faster".

There's another reason: ls-lisp implements only a subset of options
supported by 'ls' the program.

> Which may be true!  (I may be misremembering this being the
> only answer.)  Because `directory-files' uses opendir/readdir first to
> get the file names, and then we have to stat each and every file just to
> find out whether they're files or directories.
> 
> If we instead had `directory-files-with-attributes' in C, we could just
> do what "ls" does, which is...  opening the directory, reading it, and
> then statting all the files.

ls-lisp already uses directory-files-with-attributes.

> So it should be just as fast?  I think?

You should measure it, instead of trying to reason about that.  IME,
reasoning about relative timings of programs is never a good idea,
because measurements always produce surprising results.

One reason why ls-lisp might be slower is that it performs quite a bit
of processing after reading the directory, and that processing is
faster in C than in Lisp.  But it could be faster in insignificant
ways.



  parent reply	other threads:[~2016-02-20  9:57 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20  1:15 Human-readable file sorting Lars Ingebrigtsen
2016-02-20  1:58 ` John Wiegley
2016-02-20  2:26   ` Lars Ingebrigtsen
2016-02-20  2:33     ` John Wiegley
2016-02-20  6:00       ` Lars Ingebrigtsen
2016-02-20  6:12         ` Marcin Borkowski
2016-02-20  7:15           ` Lars Ingebrigtsen
2016-02-20  8:14             ` Marcin Borkowski
2016-02-22 18:09             ` Nikolaus Rath
2016-02-22 21:31               ` Marcin Borkowski
2016-02-23  6:13                 ` Yuri Khan
2016-02-23  8:32                   ` Andreas Schwab
2016-02-24  5:39                     ` Marcin Borkowski
2016-02-20  6:17         ` John Wiegley
2016-02-20  7:11           ` Lars Ingebrigtsen
2016-02-20  9:28         ` Eli Zaretskii
2016-02-20 10:24           ` martin rudalics
2016-02-20 10:53             ` Eli Zaretskii
2016-02-20 17:30         ` Michael Heerdegen
2016-02-20 18:25           ` Drew Adams
2016-02-20  6:16       ` dired and ls (was: Human-readable file sorting) Lars Ingebrigtsen
2016-02-20  6:19         ` dired and ls John Wiegley
2016-02-20  7:25           ` Lars Ingebrigtsen
2016-02-20  8:01             ` John Wiegley
2016-02-23  7:15               ` Thierry Volpiatto
2016-02-23 16:34                 ` John Wiegley
2016-02-20  9:57         ` Eli Zaretskii [this message]
2016-02-20 19:21           ` John Wiegley
2016-02-20 21:02             ` Eli Zaretskii
2016-02-20 21:24               ` John Wiegley
2016-02-21  2:10           ` Lars Ingebrigtsen
2016-02-20  8:53     ` Human-readable file sorting Eli Zaretskii
2016-02-20 11:32       ` Lars Ingebrigtsen
2016-02-20 11:36         ` Eli Zaretskii
2016-02-20 11:45           ` Lars Ingebrigtsen
2016-02-20 12:35             ` Eli Zaretskii
2016-02-21  2:14               ` Lars Ingebrigtsen
2016-02-21 23:36                 ` Richard Stallman
2016-02-22  2:58                   ` Lars Ingebrigtsen
2016-02-22 18:01                     ` Richard Stallman
2016-02-22 18:13                       ` Pierpaolo Bernardi
2016-02-22 19:00                       ` Eli Zaretskii
2016-02-23 17:43                         ` Richard Stallman
2016-02-23 18:00                           ` Eli Zaretskii
2016-02-24  1:51                             ` Lars Ingebrigtsen
2016-02-24 13:43                               ` Richard Stallman
2016-02-24 13:41                             ` Richard Stallman
2016-02-20 14:23             ` Alexis
2016-02-20 14:43               ` Eli Zaretskii
2016-02-21  2:18               ` Lars Ingebrigtsen
2016-02-21  9:30                 ` Alexis
2016-02-21 10:07                   ` Lars Ingebrigtsen
2016-02-21 19:27                   ` Yuri Khan
2016-02-21 20:21                     ` Eli Zaretskii
2016-02-20 15:35       ` Pierpaolo Bernardi
2016-02-20 15:52         ` Eli Zaretskii
2016-02-21 12:45           ` Richard Stallman
2016-02-20 16:03         ` Herring, Davis
2016-02-20 16:23           ` Paul Eggert
2016-02-21  2:20         ` Lars Ingebrigtsen
2016-02-21 12:45         ` Richard Stallman
2016-02-21  2:38     ` Stefan Monnier
2016-02-20 14:32 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k2lzpuuj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.