From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Embedded modifiers in the regex engine Date: Thu, 31 Mar 2016 19:28:28 +0300 Message-ID: <83k2kivcgj.fsf@gnu.org> References: <87ziupinhq.fsf@secretsauce.net> <83oab4g407.fsf@gnu.org> <83mvqnet3t.fsf@gnu.org> <87wpppioxi.fsf@secretsauce.net> <83povgakpy.fsf@gnu.org> <871t6v1mdb.fsf@secretsauce.net> <83oa9yy643.fsf@gnu.org> <87vb46zdf5.fsf@secretsauce.net> <834mbqxxxx.fsf@gnu.org> <87lh51yo5c.fsf@secretsauce.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459441740 12879 80.91.229.3 (31 Mar 2016 16:29:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Mar 2016 16:29:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dima Kogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 31 18:28:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1alfSr-0001L8-HE for ged-emacs-devel@m.gmane.org; Thu, 31 Mar 2016 18:28:57 +0200 Original-Received: from localhost ([::1]:33290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alfSq-0003sf-UA for ged-emacs-devel@m.gmane.org; Thu, 31 Mar 2016 12:28:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alfSe-0003sY-8x for emacs-devel@gnu.org; Thu, 31 Mar 2016 12:28:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alfSZ-00063R-GG for emacs-devel@gnu.org; Thu, 31 Mar 2016 12:28:44 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alfSZ-00063N-DV; Thu, 31 Mar 2016 12:28:39 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1819 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1alfSY-0000un-LJ; Thu, 31 Mar 2016 12:28:39 -0400 In-reply-to: <87lh51yo5c.fsf@secretsauce.net> (message from Dima Kogan on Tue, 29 Mar 2016 14:23:11 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202506 Archived-At: > From: Dima Kogan > Cc: emacs-devel@gnu.org > Date: Tue, 29 Mar 2016 14:23:11 -0700 > > >> > Also, please provide log messages for the changes. > >> > >> What kind of log messages? Git logs? These are terse because this > >> project seems to have strict guidelines, and other messages I see are > >> generally very terse. What would you like? > > > > See CONTRIBUTE: they should be Git log messages in the ChangeLog > > format. > > Can you please be more specific about what is missing in the patches I > sent? A commit log message, formatted similarly to this one: Adapt filenotify-tests.el according latest tests * test/lisp/filenotify-tests.el (file-notify-test02-events) (file-notify-test04-file-validity, file-notify-test05-dir-validity): Remove superfluous `read-event' calls. (file-notify-test02-events): Expect different events under MS Windows 7 and 10. (file-notify-test04-file-validity): Move `file-notify-valid-p' check up.