From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>, John Wiegley <johnw@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Undefined behavior in OS X unexec detected by ASan
Date: Fri, 08 Apr 2016 11:27:34 +0300 [thread overview]
Message-ID: <83k2k8jyix.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkR3sGvi1aNtS4QLT-5MMtXRA+oH5+QTa2PpaB7Ktav4Tg@mail.gmail.com> (message from Philipp Stephani on Sat, 02 Apr 2016 17:26:17 +0000)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 02 Apr 2016 17:26:17 +0000
>
> unexmacosx.c reads process memory directly, which tends to work in practice but is technically undefined
> behavior. I've attached a small patch that uses vm_read instead. According to ASan with this patch there's no
> more UB when dumping.
Would someone who uses OS X please see if this patch is OK? Are there
any version-related caveats here (e.g., could some older OS X version
have trouble with this change)?
If everything's fine with the patch, we still need to decide to which
branch this should go. John?
next prev parent reply other threads:[~2016-04-08 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 17:26 Undefined behavior in OS X unexec detected by ASan Philipp Stephani
2016-04-08 8:27 ` Eli Zaretskii [this message]
2016-04-08 16:01 ` John Wiegley
2016-05-15 19:36 ` Philipp Stephani
2016-05-15 19:54 ` Paul Eggert
2016-05-15 19:58 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k2k8jyix.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=johnw@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.