From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24358: 25.1.50; re-search-forward errors with "Variable binding depth exceeds max-specpdl-size" Date: Sun, 23 Oct 2016 22:18:25 +0300 Message-ID: <83k2cynabi.fsf@gnu.org> References: <87eg3rvtsf.fsf@users.sourceforge.net> <83k2dihpm9.fsf@gnu.org> <8760p2wzgj.fsf@users.sourceforge.net> <838ttyhhzu.fsf@gnu.org> <871szqwu51.fsf@users.sourceforge.net> <831szqhbc2.fsf@gnu.org> <87h98hujcx.fsf@users.sourceforge.net> <831szkahyz.fsf@gnu.org> <87eg3jvfj6.fsf@users.sourceforge.net> <8360ov8lbu.fsf@gnu.org> <877f95uj66.fsf@users.sourceforge.net> <83zim0vn1t.fsf@gnu.org> <874m48v7wj.fsf@users.sourceforge.net> <83insov1zr.fsf@gnu.org> <87zilztzd5.fsf@users.sourceforge.net> <83oa2ftnvp.fsf@gnu.org> <87wph2ts1a.fsf@users.sourceforge.net> <83oa2erx0k.fsf@gnu.org> <87lgxht8hp.fsf@users.sourceforge.net> <871sz8kq2v.fsf@gmail.com> <87shroroh8.fsf@users.sourceforge.net> <838ttfpnxt.fsf@gnu.org> <83vawjo21l.fsf@gnu.org> <83bmybnopx.fsf@gnu.org> <8360ojnk0n.fsf@gnu.org> <83twc3m198.fsf@gnu.org> <83pomrlz27.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1477250371 14263 195.159.176.226 (23 Oct 2016 19:19:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Oct 2016 19:19:31 +0000 (UTC) Cc: sam.halliday@gmail.com, 24358@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 23 21:19:27 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byOIW-0000o7-7M for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2016 21:19:08 +0200 Original-Received: from localhost ([::1]:42144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byOIY-0000MN-Kx for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2016 15:19:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byOIT-0000MI-9i for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 15:19:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byOIQ-0000Xp-4S for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 15:19:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1byOIQ-0000Xk-0W for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 15:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1byOIP-0007xJ-R5 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 15:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2016 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 24358-submit@debbugs.gnu.org id=B24358.147725032030547 (code B ref 24358); Sun, 23 Oct 2016 19:19:01 +0000 Original-Received: (at 24358) by debbugs.gnu.org; 23 Oct 2016 19:18:40 +0000 Original-Received: from localhost ([127.0.0.1]:49884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byOI4-0007wd-G5 for submit@debbugs.gnu.org; Sun, 23 Oct 2016 15:18:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byOI2-0007wP-KZ for 24358@debbugs.gnu.org; Sun, 23 Oct 2016 15:18:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byOHu-0000SF-8H for 24358@debbugs.gnu.org; Sun, 23 Oct 2016 15:18:33 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byOHu-0000SB-5A; Sun, 23 Oct 2016 15:18:30 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3297 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1byOHt-0006yd-D8; Sun, 23 Oct 2016 15:18:29 -0400 In-reply-to: (message from Noam Postavsky on Sun, 23 Oct 2016 14:14:59 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124930 Archived-At: > From: Noam Postavsky > Date: Sun, 23 Oct 2016 14:14:59 -0400 > Cc: Sam Halliday , 24358@debbugs.gnu.org > > On Sun, Oct 23, 2016 at 2:06 PM, Eli Zaretskii wrote: > > Noam, I think we need these two changes, because otherwise looping > > more than once in search_buffer will fail to update the pointers > > passed to re_search_2, if buffer text was relocated inside > > re_search_2. > > > > Do you agree? > > Ack, yes! Missing the update to base was a total thinko on my part. Pushed. There might be a more serious problem with this, unfortunately: the search registers are computed in regex.c using pointers into the C strings that are being searched. The general paradigm is as in this fragment: regstart[*p] = d; [...] regs->start[reg] = POINTER_TO_OFFSET (regstart[reg]); POINTER_TO_OFFSET assumes that the pointer in regstart[reg] is consistent with the current base address of the string into which it points. Did you study this aspect of regex.c when you decided which values need to be affected by relocation?