all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Wolfgang Jenkner <wjenkner@inode.at>
Cc: erik@selberg.org, emacs-devel@gnu.org
Subject: Re: comint fix for shell colors
Date: Fri, 18 Nov 2016 16:40:52 +0200	[thread overview]
Message-ID: <83k2c0df63.fsf@gnu.org> (raw)
In-Reply-To: <582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at> (message from Wolfgang Jenkner on Fri, 18 Nov 2016 15:25:41 +0100)

> Date: Fri, 18 Nov 2016 15:25:41 +0100
> From: Wolfgang Jenkner <wjenkner@inode.at>
> Cc: emacs-devel@gnu.org
> 
> In emacs-25 and master comint-highlight-prompt is prepended to
> ansi-color faces used for highlighting prompts.  The user has just
> to customize the comint-highlight-prompt face so that it doesn't
> inherit from minibuffer-prompt and it won't clobber anything.  See
> 
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20084
> 
> commit 792d44b3c31d2a682607ab8b79ae7d26b7402f41

Thanks.  (I wonder why you didn't respond to the original message --
it was posted 4 days ago, and I waited for someone knowledgeable to
chime in before replying.)

> So I think there's nothing to do here execept perhaps for documenting
> something.

Indeed, I think this change should be described in NEWS.  Could you
provide a patch for that, please?



  reply	other threads:[~2016-11-18 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15  7:14 comint fix for shell colors Erik Selberg
2016-11-18 10:07 ` Eli Zaretskii
2016-11-18 14:25   ` Wolfgang Jenkner
2016-11-18 14:40     ` Eli Zaretskii [this message]
2016-11-18 15:06       ` Wolfgang Jenkner
2016-11-18 15:34         ` Eli Zaretskii
2016-11-18 15:40           ` Erik Selberg
2016-11-18 15:49           ` Wolfgang Jenkner
2016-11-18 15:53             ` Erik Selberg
2016-11-18 19:24               ` Erik Selberg
2016-11-18 19:50                 ` Eli Zaretskii
2016-11-18 22:43                   ` Erik Selberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k2c0df63.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=erik@selberg.org \
    --cc=wjenkner@inode.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.