From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master 0a5b6e2: Fix aborts in GC under
	GC_CHECK_MARKED_OBJECTS
Date: Thu, 22 Dec 2016 18:14:39 +0200
Message-ID: <83k2as0wls.fsf@gnu.org>
References: <20161221201813.3130.28327@vcs.savannah.gnu.org>
	<20161221201813.A13CA2201BA@vcs.savannah.gnu.org>
	<r025fulgiodr.fsf@dancol.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1482423367 14301 195.159.176.226 (22 Dec 2016 16:16:07 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Thu, 22 Dec 2016 16:16:07 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Daniel Colascione <dancol@dancol.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 22 17:15:59 2016
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1cK622-0001zo-3l
	for ged-emacs-devel@m.gmane.org; Thu, 22 Dec 2016 17:15:50 +0100
Original-Received: from localhost ([::1]:34991 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1cK626-0007tO-PF
	for ged-emacs-devel@m.gmane.org; Thu, 22 Dec 2016 11:15:54 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1cK61N-0007gb-3L
	for emacs-devel@gnu.org; Thu, 22 Dec 2016 11:15:10 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1cK61I-00014W-7s
	for emacs-devel@gnu.org; Thu, 22 Dec 2016 11:15:09 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37437)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1cK61I-00014S-4y; Thu, 22 Dec 2016 11:15:04 -0500
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1077
	helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1cK61H-0005ud-FQ; Thu, 22 Dec 2016 11:15:03 -0500
In-reply-to: <r025fulgiodr.fsf@dancol.org> (message from Daniel Colascione on
	Wed, 21 Dec 2016 20:22:40 -0800)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:210732
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/210732>

> From: Daniel Colascione <dancol@dancol.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Wed, 21 Dec 2016 20:22:40 -0800
> 
> >  #ifdef GC_CHECK_MARKED_OBJECTS
> >  	m = mem_find (po);
> > -	if (m == MEM_NIL && !SUBRP (obj))
> > +	if (m == MEM_NIL && !SUBRP (obj) && !THREADP (obj))
> 
> This code is incorrect.  The only special case is po == &primary_thread.
> As I mentioned in another message, all _other_ thread objects live in
> dynamic storage and need the usual treatment of thread objects.

Thanks, fixed.