From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: ctl-x-map key binding conventions for new major/minor modes Date: Sat, 13 May 2017 17:33:43 +0300 Message-ID: <83k25k967s.fsf@gnu.org> References: <83vap58c4t.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494686095 23441 195.159.176.226 (13 May 2017 14:34:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 May 2017 14:34:55 +0000 (UTC) Cc: emacs-devel@gnu.org, drew.adams@oracle.com, tino.calancha@gmail.com To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 13 16:34:51 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9Y8A-0005zI-IJ for ged-emacs-devel@m.gmane.org; Sat, 13 May 2017 16:34:50 +0200 Original-Received: from localhost ([::1]:57807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9Y8G-00024Q-0t for ged-emacs-devel@m.gmane.org; Sat, 13 May 2017 10:34:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9Y7S-00020o-L1 for emacs-devel@gnu.org; Sat, 13 May 2017 10:34:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9Y7P-0000rt-KB for emacs-devel@gnu.org; Sat, 13 May 2017 10:34:06 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9Y7P-0000ri-HS; Sat, 13 May 2017 10:34:03 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4945 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d9Y7O-0004Qw-KF; Sat, 13 May 2017 10:34:03 -0400 In-reply-to: (message from Kaushal Modi on Sat, 13 May 2017 14:16:46 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214818 Archived-At: > From: Kaushal Modi > Date: Sat, 13 May 2017 14:16:46 +0000 > Cc: drew.adams@oracle.com, emacs-devel@gnu.org > > Perhaps instead of adding recommendations about this, we could have a > feature where define-key invoked as part as 'load' or 'require' would > check, once, if the key being rebound already has a binding, > > and ask > the user what she would like to do about, with 3 possible answers > being "rebind", "don't rebind", and "error out of 'load'"? > > Would that halt emacs startup with that prompt? It would stop the load of the features which redefines the keys. > If so, I believe that would cause an annoyance for a lot of > users who might have already shadowed bindings. That's why I proposed to do that only once, the first time this ever happens for a key or a group of keys. > What if define-key is instead made to throw a message or a warning? What's the difference between a message and a warning? Anyway, this could also be good, but its disadvantage is that it doesn't let the user an opportunity to reject the rebinding. > (define-key KEYMAP KEY DEF) > > If it is made into > > (define-key KEYMAP KEY DEF &optional ALLOW-OVERRIDE) > > - By default, the overriding will happen as now, but the above mentioned warning will also be put out in > *Messages*. > - If ALLOW-OVERRIDE is 'prevent, the overriding will be blocked silently. > - If ALLOW-OVERRIDE is any other non-nil value, overriding will happen and that warning is not thrown. I think this should be an interactive feature, not a non-interactive one.