From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25355: 26.0.50; Provide function to non-destructively replace buffer contents Date: Sat, 17 Jun 2017 19:06:45 +0300 Message-ID: <83k24azjhm.fsf@gnu.org> References: <8337cgee4h.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1497715692 9514 195.159.176.226 (17 Jun 2017 16:08:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Jun 2017 16:08:12 +0000 (UTC) Cc: 25355@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 17 18:08:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMGGe-0002GQ-BU for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 18:08:08 +0200 Original-Received: from localhost ([::1]:35649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMGGj-0002P2-E0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Jun 2017 12:08:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMGGb-0002Ov-H2 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 12:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMGGY-0001MS-Ch for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 12:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMGGY-0001MG-8m for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 12:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMGGY-0006Wc-0C for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 12:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2017 16:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25355-submit@debbugs.gnu.org id=B25355.149771563325026 (code B ref 25355); Sat, 17 Jun 2017 16:08:01 +0000 Original-Received: (at 25355) by debbugs.gnu.org; 17 Jun 2017 16:07:13 +0000 Original-Received: from localhost ([127.0.0.1]:53573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMGFk-0006Va-TW for submit@debbugs.gnu.org; Sat, 17 Jun 2017 12:07:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMGFi-0006VM-Gj for 25355@debbugs.gnu.org; Sat, 17 Jun 2017 12:07:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMGFa-0000w8-8g for 25355@debbugs.gnu.org; Sat, 17 Jun 2017 12:07:05 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMGFa-0000w0-4y; Sat, 17 Jun 2017 12:07:02 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2363 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dMGFZ-0004iL-AE; Sat, 17 Jun 2017 12:07:01 -0400 In-reply-to: (message from Philipp Stephani on Sat, 17 Jun 2017 13:47:48 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133703 Archived-At: > From: Philipp Stephani > Date: Sat, 17 Jun 2017 13:47:48 +0000 > Cc: 25355-done@debbugs.gnu.org > > Apparently I didn't look closely enough: Diffutils uses an implementation of the Myers algorithm from > Gnulib, which is customizable enough to fit our needs. I've attached a patch that uses Gnulib. > > I've pushed a slightly modified version of this patch as d682f0daa3. Thanks. Could you also update the manuals with the information about the new function? After doing that, please mark the NEWS entry with "+++". Btw, while compiling I see this warning: In file included from editfns.c:3139:0: ../lib/diffseq.h: In function 'diag': ../lib/diffseq.h:210:12: warning: variable 'big_snake' set but not used [-Wunused-but-set-variable] bool big_snake = false; ^