From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28033: [PATCH] Add new face 'header-line-highlight' Date: Fri, 11 Aug 2017 19:15:30 +0300 Message-ID: <83k22aqdwd.fsf@gnu.org> References: <87bmno7228.fsf@lylat> <83k22crrfg.fsf@gnu.org> <874ltg6l2k.fsf@lylat> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502468178 21431 195.159.176.226 (11 Aug 2017 16:16:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 11 Aug 2017 16:16:18 +0000 (UTC) Cc: 28033@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 11 18:16:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgCbX-0004yU-GC for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Aug 2017 18:16:07 +0200 Original-Received: from localhost ([::1]:53637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgCbd-00066c-He for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Aug 2017 12:16:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgCbT-00064M-Mu for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 12:16:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgCbS-0004WW-45 for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 12:16:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47244) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgCbR-0004WJ-S8 for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 12:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgCbR-0003o4-MG for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 12:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2017 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28033 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28033-submit@debbugs.gnu.org id=B28033.150246815714615 (code B ref 28033); Fri, 11 Aug 2017 16:16:01 +0000 Original-Received: (at 28033) by debbugs.gnu.org; 11 Aug 2017 16:15:57 +0000 Original-Received: from localhost ([127.0.0.1]:55925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgCbM-0003nf-VL for submit@debbugs.gnu.org; Fri, 11 Aug 2017 12:15:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgCbL-0003nT-1m for 28033@debbugs.gnu.org; Fri, 11 Aug 2017 12:15:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgCbB-0004JJ-GI for 28033@debbugs.gnu.org; Fri, 11 Aug 2017 12:15:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgCbB-0004JB-Ao; Fri, 11 Aug 2017 12:15:45 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4846 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dgCbA-0005p5-2W; Fri, 11 Aug 2017 12:15:45 -0400 In-reply-to: <874ltg6l2k.fsf@lylat> (message from Alex on Wed, 09 Aug 2017 23:36:19 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135659 Archived-At: > From: Alex > Cc: 28033@debbugs.gnu.org > Date: Wed, 09 Aug 2017 23:36:19 -0600 > > The problem is that the highlight face, which is used for highlighting > links and other mouse-sensitive buffer text frequently, may not always > look nice with the header-line face. I've attached a picture > demonstrating one possible issue. In it, the header-line face has a :box > attribute with line-width 4, but the highlight face does not. This > results in the characters at the ends being clipped. > > A new face allows for users to customize it to match the customization > of the header-line face while not affecting all other uses of the > highlight face. > > I believe the use case of this face is very similar to > 'mode-line-highlight', which was added quite a while ago. Thanks, this makes sense. But please add some of this rationale to the documentation. Also, it is preferable to have the first line of a NEWS item be a full sentence, if possible. In this case, I would just say ** New face 'header-line-highlight'. and then follow that by the details.