all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alex <agrambot@gmail.com>
Cc: 28033@debbugs.gnu.org
Subject: bug#28033: [PATCH] Add new face 'header-line-highlight'
Date: Fri, 11 Aug 2017 19:15:30 +0300	[thread overview]
Message-ID: <83k22aqdwd.fsf@gnu.org> (raw)
In-Reply-To: <874ltg6l2k.fsf@lylat> (message from Alex on Wed, 09 Aug 2017 23:36:19 -0600)

> From: Alex <agrambot@gmail.com>
> Cc: 28033@debbugs.gnu.org
> Date: Wed, 09 Aug 2017 23:36:19 -0600
> 
> The problem is that the highlight face, which is used for highlighting
> links and other mouse-sensitive buffer text frequently, may not always
> look nice with the header-line face. I've attached a picture
> demonstrating one possible issue. In it, the header-line face has a :box
> attribute with line-width 4, but the highlight face does not. This
> results in the characters at the ends being clipped.
> 
> A new face allows for users to customize it to match the customization
> of the header-line face while not affecting all other uses of the
> highlight face.
> 
> I believe the use case of this face is very similar to
> 'mode-line-highlight', which was added quite a while ago.

Thanks, this makes sense.  But please add some of this rationale to
the documentation.

Also, it is preferable to have the first line of a NEWS item be a full
sentence, if possible.  In this case, I would just say

  ** New face 'header-line-highlight'.

and then follow that by the details.





  reply	other threads:[~2017-08-11 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 23:29 bug#28033: [PATCH] Add new face 'header-line-highlight' Alex
2017-08-10  4:13 ` Eli Zaretskii
2017-08-10  5:36   ` Alex
2017-08-11 16:15     ` Eli Zaretskii [this message]
2017-08-11 22:10       ` Alex
2017-08-12  7:20         ` Eli Zaretskii
2017-08-13  3:05           ` Alex
2017-08-13 14:27             ` Eli Zaretskii
2017-08-13 14:59               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k22aqdwd.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28033@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.