From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: call-process blocks the active thread Date: Fri, 08 Sep 2017 15:16:35 +0300 Message-ID: <83k219xu58.fsf@gnu.org> References: <837ex9znba.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1504873048 9562 195.159.176.226 (8 Sep 2017 12:17:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Sep 2017 12:17:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: Elias =?utf-8?Q?M=C3=A5rtenson?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 08 14:17:18 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqIDh-0001ky-Fr for ged-emacs-devel@m.gmane.org; Fri, 08 Sep 2017 14:17:13 +0200 Original-Received: from localhost ([::1]:45199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqIDo-0006gq-8d for ged-emacs-devel@m.gmane.org; Fri, 08 Sep 2017 08:17:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqIDD-0006gj-Hh for emacs-devel@gnu.org; Fri, 08 Sep 2017 08:16:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqID9-00062K-7k for emacs-devel@gnu.org; Fri, 08 Sep 2017 08:16:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqID9-00062D-3r; Fri, 08 Sep 2017 08:16:39 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3441 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dqID7-0000T8-ET; Fri, 08 Sep 2017 08:16:38 -0400 In-reply-to: (message from Elias =?utf-8?Q?M=C3=A5rtenson?= on Fri, 8 Sep 2017 18:36:17 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218015 Archived-At: > From: Elias Mårtenson > Date: Fri, 8 Sep 2017 18:36:17 +0800 > Cc: emacs-devel > > This is not a bug. > > I'm not entirely sure why you feel that distinction is important. I thought you were reporting it as a bug, so it was important for me to say Emacs was working as designed in this case. > At the end of the day, it's ‘start-process’ that > doesn't yield while the external process runs. Is there a reason why it can't be changed so that it does? AFAIU, it would require significant changes in how call-process works, both how it waits for the child process to exit and how it reads the sub-process output. And start-process already has all that figured out, so I think it's easier to just use it, especially since threading already supports start-process, in that the calling thread will yield automatically while it reads sub-process output and/or waits for it to exit. Of course, it's possible I don't see some clever way to make call-process thread-aware, which is why I said that if someone has concrete ideas for how to do that, they are encouraged to speak up.