From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28809: 26.0.90; Error running timer =?UTF-8?Q?=E2=80=98image-dired-thumb-queue-run=E2=80=99?= Date: Mon, 16 Oct 2017 19:28:00 +0300 Message-ID: <83k1zvf46n.fsf@gnu.org> References: <83mv4vjewg.fsf@gnu.org> <20171014212459.zzzjveby4g32a35i@logos.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1508171370 17780 195.159.176.226 (16 Oct 2017 16:29:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 16:29:30 +0000 (UTC) Cc: rotim.davor@gmail.com, 28809-done@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 16 18:29:24 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e48GJ-0002IY-SO for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 18:29:07 +0200 Original-Received: from localhost ([::1]:34017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e48GR-0000ZN-8T for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Oct 2017 12:29:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e48GH-0000XU-DY for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 12:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e48GE-0002ee-6f for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 12:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35413) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e48GE-0002eX-3H for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 12:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e48GD-0003T2-St for bug-gnu-emacs@gnu.org; Mon, 16 Oct 2017 12:29:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2017 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 28809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 28809@debbugs.gnu.org, eliz@gnu.org, rotim.davor@gmail.com Original-Received: via spool by 28809-done@debbugs.gnu.org id=D28809.150817130913281 (code D ref 28809); Mon, 16 Oct 2017 16:29:01 +0000 Original-Received: (at 28809-done) by debbugs.gnu.org; 16 Oct 2017 16:28:29 +0000 Original-Received: from localhost ([127.0.0.1]:44093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e48Fg-0003S8-Pq for submit@debbugs.gnu.org; Mon, 16 Oct 2017 12:28:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e48Ff-0003Rw-Et for 28809-done@debbugs.gnu.org; Mon, 16 Oct 2017 12:28:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e48FX-0002FF-5L for 28809-done@debbugs.gnu.org; Mon, 16 Oct 2017 12:28:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e48FW-0002Ew-SG; Mon, 16 Oct 2017 12:28:19 -0400 Original-Received: from [176.228.60.248] (port=2025 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e48FW-0000cx-7T; Mon, 16 Oct 2017 12:28:18 -0400 In-reply-to: <20171014212459.zzzjveby4g32a35i@logos.localdomain> (message from Mark Oteiza on Sat, 14 Oct 2017 17:24:59 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138536 Archived-At: > Date: Sat, 14 Oct 2017 17:24:59 -0400 > From: Mark Oteiza > Cc: Davor Rotim , 28809@debbugs.gnu.org > > On 13/10/17 at 05:33pm, Eli Zaretskii wrote: > > > From: Davor Rotim > > > Date: Fri, 13 Oct 2017 15:33:24 +0200 > > > > > > Started with emacs -Q, opened a dired buffer, navigated to an image and pressed C-t . > > > on it (image-dired-display-thumb) to generate a thumbnail. That leaves me with only an error message: > > > > > > Error running timer ‘image-dired-thumb-queue-run’: (range-error "floor" 1505334534.0059688) > > > > Mark, could you please look at this? You changed the code to use > > floor instead of rounding via format "%.0f", but floor returns an > > Emacs integer which can overflow on 32-bit hosts for large time > > values, as happens here. I think we should use ffloor instead, and if > > that produces a decimal point, eliminate it with "%.0f" format. > > What you propose sounds fine to me. Done.