From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#30697: make eval-expression only take `read'-able Lisp
Date: Sun, 04 Mar 2018 19:10:55 +0200
Message-ID: <83k1uru5pc.fsf@gnu.org>
References: <m27eqriyat.fsf@aurox.ch>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1520183416 29109 195.159.176.226 (4 Mar 2018 17:10:16 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Sun, 4 Mar 2018 17:10:16 +0000 (UTC)
Cc: 30697@debbugs.gnu.org
To: charles@aurox.ch (Charles A. Roelli)
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 04 18:10:12 2018
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1esX9E-0006i1-Gm
	for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Mar 2018 18:10:08 +0100
Original-Received: from localhost ([::1]:45580 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1esXBG-0006TA-Ud
	for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Mar 2018 12:12:14 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esXB9-0006Ss-Em
	for bug-gnu-emacs@gnu.org; Sun, 04 Mar 2018 12:12:08 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esXB4-0000mD-GH
	for bug-gnu-emacs@gnu.org; Sun, 04 Mar 2018 12:12:07 -0500
Original-Received: from debbugs.gnu.org ([208.118.235.43]:36751)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1esXB4-0000lm-BU
	for bug-gnu-emacs@gnu.org; Sun, 04 Mar 2018 12:12:02 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esXB4-0007yR-4b
	for bug-gnu-emacs@gnu.org; Sun, 04 Mar 2018 12:12:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Eli Zaretskii <eliz@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Sun, 04 Mar 2018 17:12:02 +0000
Resent-Message-ID: <handler.30697.B30697.152018348230599@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 30697
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
Original-Received: via spool by 30697-submit@debbugs.gnu.org id=B30697.152018348230599
	(code B ref 30697); Sun, 04 Mar 2018 17:12:02 +0000
Original-Received: (at 30697) by debbugs.gnu.org; 4 Mar 2018 17:11:22 +0000
Original-Received: from localhost ([127.0.0.1]:44648 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1esXAQ-0007xR-H5
	for submit@debbugs.gnu.org; Sun, 04 Mar 2018 12:11:22 -0500
Original-Received: from eggs.gnu.org ([208.118.235.92]:34858)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <eliz@gnu.org>) id 1esXAO-0007xF-VM
	for 30697@debbugs.gnu.org; Sun, 04 Mar 2018 12:11:21 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1esXAE-0000Xb-W4
	for 30697@debbugs.gnu.org; Sun, 04 Mar 2018 12:11:15 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39429)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1esXAE-0000XX-SZ; Sun, 04 Mar 2018 12:11:10 -0500
Original-Received: from [176.228.60.248] (port=3433 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1esXAE-0008I1-9n; Sun, 04 Mar 2018 12:11:10 -0500
In-reply-to: <m27eqriyat.fsf@aurox.ch> (charles@aurox.ch)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
	the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-emacs/>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
	<bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.bugs:143898
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/143898>

> Date: Sun, 04 Mar 2018 17:46:18 +0100
> From: charles@aurox.ch (Charles A. Roelli)
> 
> Here is a change to make eval-expression issue a warning in the
> minibuffer when the user enters an unreadable expression.  Currently,
> we just error out, so the user has to restart the command and go back
> in the history to get back what he typed.
> 
> With the change applied, if you type
> 
> M-: ( RET
> 
> from emacs -q, you'll see,
> 
> Eval: ( [End of file during parsing]
> 
> which gives you a chance to fix the error right away.
> 
> As another example, if you type an extra paren, as in
> 
> M-: ( ) ) RET
> 
> you'll see,
> 
> Eval: ()) [Trailing garbage following expression]
> 
> and point is left at the extra paren.

You are changing the behavior of read--expression, which has a few
callers in Emacs.  Did you verify that those callers won't break due
to this change?

This should also have a NEWS entry, and perhaps the manual needs some
changes, please take a look.

Thanks.