From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31676: 27.0.50; More helpful error message for unescaped character literals Date: Sat, 09 Jun 2018 20:31:25 +0300 Message-ID: <83k1r7sw7m.fsf@gnu.org> References: <837en9uyaq.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1528565410 16900 195.159.176.226 (9 Jun 2018 17:30:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Jun 2018 17:30:10 +0000 (UTC) Cc: larsi@gnus.org, 31676@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 09 19:30:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRhgj-0004ID-HP for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 19:30:05 +0200 Original-Received: from localhost ([::1]:41077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRhiq-0005pk-EB for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jun 2018 13:32:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRhig-0005pd-L3 for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 13:32:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRhic-0003rO-L3 for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 13:32:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33594) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRhic-0003rC-Gi for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 13:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRhic-0002Gb-7w for bug-gnu-emacs@gnu.org; Sat, 09 Jun 2018 13:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jun 2018 17:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31676-submit@debbugs.gnu.org id=B31676.15285655028689 (code B ref 31676); Sat, 09 Jun 2018 17:32:02 +0000 Original-Received: (at 31676) by debbugs.gnu.org; 9 Jun 2018 17:31:42 +0000 Original-Received: from localhost ([127.0.0.1]:41491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRhiE-0002G1-LQ for submit@debbugs.gnu.org; Sat, 09 Jun 2018 13:31:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRhi9-0002Fl-8g for 31676@debbugs.gnu.org; Sat, 09 Jun 2018 13:31:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRhhz-0003Th-E3 for 31676@debbugs.gnu.org; Sat, 09 Jun 2018 13:31:28 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRhhz-0003TZ-9V; Sat, 09 Jun 2018 13:31:23 -0400 Original-Received: from [176.228.60.248] (port=1551 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRhhx-0003XB-Bf; Sat, 09 Jun 2018 13:31:22 -0400 In-reply-to: (message from Philipp Stephani on Sat, 9 Jun 2018 19:12:30 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147248 Archived-At: > From: Philipp Stephani > Date: Sat, 9 Jun 2018 19:12:30 +0200 > Cc: larsi@gnus.org, 31676@debbugs.gnu.org > > Sounds okay, but can you tell why you implemented > lread--unescaped-character-literals in C? If that's because you need > to call it from load_warn_unescaped_character_literals, then C > functions can call Lisp functions with no problems, we have several > examples of that in the sources. AFAICT, the C implementation is just > a "transliteration" of straightforward Lisp code, so it reads strange. > > The function uses an uninterned variable, so it has to be in C. I think that's slightly better than interning the > variable and having some Lisp function access it (the latter would have one additional internal symbol). Why does it need an uninterned variable? And if it does, why cannot it create a symbol that is not in obarray?