From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: wildgruber@tu-berlin.de, emacs-devel@gnu.org
Subject: Re: follow-mode: extremely slow in combination with org-mode
Date: Sun, 17 Jun 2018 16:02:26 +0300 [thread overview]
Message-ID: <83k1qxtvkt.fsf@gnu.org> (raw)
In-Reply-To: <20180617111333.GA12093@ACM> (message from Alan Mackenzie on Sun, 17 Jun 2018 11:13:33 +0000)
> Date: Sun, 17 Jun 2018 11:13:33 +0000
> Cc: Gerald Wildgruber <wildgruber@tu-berlin.de>, emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> On Sun, Jun 17, 2018 at 11:12:39 +0300, Eli Zaretskii wrote:
> > > From: Gerald Wildgruber <wildgruber@tu-berlin.de>
> > > CC: <emacs-devel@gnu.org>
> > > Date: Sun, 17 Jun 2018 08:57:22 +0200
>
> > > - follow-windows-start-end 17606 57%
> > > - if 17606 57%
> > > - let 17603 57%
> > > - let 17603 57%
> > > - while 17603 57%
> > > - setq 17599 57%
> > > - cons 17599 57%
> > > - cons 17599 57%
> > > - cons 17599 57%
> > > - follow-calc-win-end 17591 57%
> > > - let* 17591 57%
> > > - if 9229 30%
> > > + let 1115 3%
> > > + pos-visible-in-window-p 26 0%
> > > posn-point 8350 27%
> > > + window-inside-pixel-edges 12 0%
>
> > Alan, why doesn't follow-calc-win-end doesn't just use window-end with
> > last argument non-nil? AFAU, that should allow you to compute the
> > result using 1/4 of the processing time you now invest. Why do you
> > need all the rest in that function? What am I missing?
>
> I honestly don't know for sure. But on 2014-04-27 I made a note in my
> personal log:
>
> "In follow-calc-win-end, we check for EOB being visible in the
> window, rather than being the window-end. There needs to be a
> comment here about what the last element means."
>
> . I wish I could decipher what I meant, then. I think I might have
> encountered a corner case, where EOB is _inside_ a window, possibly not
> even the last window, and using window-end failed for some reason.
>
> But I think follow-calc-win-end was in the original follow.el written by
> Anders Lindgren. Maybe, back in the mists of time, window-end didn't
> work for some reason - maybe it hadn't yet acquired it's UPDATE
> argument, or something like that.
OK, thanks for the explanations.
Gerald, could you try the following patch to follow-calc-win-end?
Please first see if this makes it significantly faster in your use
cases, and if so, please run with it for a while and see if there are
some adverse effects. (If this is not faster, it isn't worth testing
it more.)
diff --git a/lisp/follow.el b/lisp/follow.el
index fd397c0..c99fc93 100644
--- a/lisp/follow.el
+++ b/lisp/follow.el
@@ -925,14 +925,17 @@ follow-calc-win-end
the last fully-visible line in WIN. END-OF-BUFFER is t when EOB
is fully-visible in WIN. If WIN is nil, the selected window is
used."
- (let* ((win (or win (selected-window)))
- (edges (window-inside-pixel-edges win))
- (ht (- (nth 3 edges) (nth 1 edges)))
- (last-line-pos (posn-point (posn-at-x-y 0 (1- ht) win))))
- (if (pos-visible-in-window-p last-line-pos win)
- (let ((end (window-end win t)))
- (list end (pos-visible-in-window-p (point-max) win)))
- (list last-line-pos nil))))
+ (or win (setq win (selected-window)))
+ (with-selected-window win
+ (let* ((wend (window-end win t))
+ (endp (= wend (point-max))))
+ (and (> wend (point-min))
+ (setq wend (1- wend)))
+ (setq wend
+ (save-excursion
+ (goto-char wend)
+ (line-beginning-position)))
+ (list wend endp))))
(defun follow-calc-win-start (windows pos win)
"Determine the start of window WIN in a Follow mode window chain.
next prev parent reply other threads:[~2018-06-17 13:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-16 10:25 follow-mode: extremely slow in combination with org-mode Gerald Wildgruber
2018-06-16 11:41 ` Eli Zaretskii
2018-06-16 13:06 ` Gerald Wildgruber
2018-06-16 16:25 ` Eli Zaretskii
2018-06-16 21:05 ` Gerald Wildgruber
2018-06-17 6:57 ` Gerald Wildgruber
2018-06-17 8:12 ` Eli Zaretskii
2018-06-17 11:13 ` Alan Mackenzie
2018-06-17 13:02 ` Eli Zaretskii [this message]
2018-06-17 14:56 ` Gerald Wildgruber
2018-06-17 15:10 ` Eli Zaretskii
2018-06-19 12:08 ` Gerald Wildgruber
2018-06-19 16:55 ` Eli Zaretskii
2018-06-19 13:53 ` Gerald Wildgruber
2018-06-17 15:13 ` Eli Zaretskii
2018-06-21 8:25 ` Anders Lindgren
2018-06-27 16:43 ` Gerald Wildgruber
2018-07-09 20:12 ` Anders Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k1qxtvkt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=wildgruber@tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.