From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src Date: Sun, 05 Aug 2018 20:58:41 +0300 Message-ID: <83k1p4snji.fsf@gnu.org> References: <20180717234729.15507-1-eggert@cs.ucla.edu> <83va9c33kk.fsf@gnu.org> <15823bbe-8298-0d69-c7a6-edf2001e4513@cs.ucla.edu> <83a7q2t9zh.fsf@gnu.org> <2d8e4d2b-c6b1-4e39-dfb0-d10b75d9caf8@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533491830 5763 195.159.176.226 (5 Aug 2018 17:57:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Aug 2018 17:57:10 +0000 (UTC) Cc: 32194@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 05 19:57:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmNH8-0001OV-3n for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Aug 2018 19:57:06 +0200 Original-Received: from localhost ([::1]:59422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmNJD-0007rr-32 for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Aug 2018 13:59:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmNJ3-0007ra-FC for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2018 13:59:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmNJ0-0004Wv-DR for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2018 13:59:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37032) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmNJ0-0004Wb-80 for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2018 13:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fmNJ0-00017f-0i for bug-gnu-emacs@gnu.org; Sun, 05 Aug 2018 13:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Aug 2018 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32194 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32194-submit@debbugs.gnu.org id=B32194.15334919374304 (code B ref 32194); Sun, 05 Aug 2018 17:59:01 +0000 Original-Received: (at 32194) by debbugs.gnu.org; 5 Aug 2018 17:58:57 +0000 Original-Received: from localhost ([127.0.0.1]:42050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmNIv-00017M-04 for submit@debbugs.gnu.org; Sun, 05 Aug 2018 13:58:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmNIt-00017A-AX for 32194@debbugs.gnu.org; Sun, 05 Aug 2018 13:58:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmNIl-0004Lq-4f for 32194@debbugs.gnu.org; Sun, 05 Aug 2018 13:58:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmNIk-0004Lk-WA; Sun, 05 Aug 2018 13:58:47 -0400 Original-Received: from [176.228.60.248] (port=3758 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fmNIk-00061t-C2; Sun, 05 Aug 2018 13:58:46 -0400 In-reply-to: <2d8e4d2b-c6b1-4e39-dfb0-d10b75d9caf8@cs.ucla.edu> (message from Paul Eggert on Sat, 4 Aug 2018 16:34:33 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149269 Archived-At: > Cc: 32194@debbugs.gnu.org > From: Paul Eggert > Date: Sat, 4 Aug 2018 16:34:33 -0700 > > > I'd only ask that the > > renaming be done as a separate commit before the rest of the changes > > in those two files, so that all the changes in src/regex.[ch] will be > > after the rename, as that will make future forensics easier. > > OK, will do. Thanks. > >>> P.S. Is it true that this version will no longer support a build with > >>> WIDE_CHAR_SUPPORT undefined, i.e. those which have only the C locale? > >> > >> I don't see any issues with such a build. What sort of problem do you > >> have in mind? > > > > AFAIU, you suggest removing the !WIDE_CHAR_SUPPORT code, but we > > previously supported platforms that don't have all the prerequisites > > for using that code. > > If I understand you correctly, I doubt whether such platforms survive now. If > they do we can add Gnulib-based substitutes for the missing prerequisites. I > already did that in Bug#32194#5; you suggested in Bug#32194#8 point (3) that we > not bother with it, though, and this seemed like good idea so that's what in the > current proposal. No, I was talking about src/regex.c, not Gnulib regex. But it turns out I've misread the patch: you are actually leaving the !WIDE_CHAR_SUPPORT code intact, since Emacs needs that on all platforms. So please ignore that comment. > > we should compare the performance of etags before and > > after the switch, just to be sure we aren't going to suffer a > > performance penalty. > > I expect there to be a performance penalty but it's no big deal. On my old > Fedora 28 x86-64 platform with 'make TAGS CFLAGS='-O2 -march=native"' in the > Emacs src directory, user+system time grows from 0.55 to 0.59 seconds, about a > 10% slowdown. It grows about 10% more, to 0.64 seconds, if I use the > system-installed regex library instead of the Gnulib-supplied one. I don't view > an extra tenth of a second as a glitch big enough to be worth investigating. 10% doesn't sound significant to me, thanks.