From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFC]: replace-region-contents Date: Tue, 05 Feb 2019 18:36:14 +0200 Message-ID: <83k1ietcox.fsf@gnu.org> References: <871s4rqk7u.fsf@gnu.org> <87o97syvno.fsf@gnu.org> <878syubwv3.fsf@gnu.org> <87y36u9xqt.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="117270"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 05 17:36:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gr3iO-000UJS-5B for ged-emacs-devel@m.gmane.org; Tue, 05 Feb 2019 17:36:52 +0100 Original-Received: from localhost ([127.0.0.1]:34583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr3iN-0007bL-5F for ged-emacs-devel@m.gmane.org; Tue, 05 Feb 2019 11:36:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr3iB-0007Zg-Lt for emacs-devel@gnu.org; Tue, 05 Feb 2019 11:36:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gr3hz-0005xj-Fh; Tue, 05 Feb 2019 11:36:29 -0500 Original-Received: from [176.228.60.248] (port=3389 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gr3hy-00052x-2H; Tue, 05 Feb 2019 11:36:26 -0500 In-reply-to: <87y36u9xqt.fsf@gnu.org> (message from Tassilo Horn on Tue, 05 Feb 2019 14:21:46 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233004 Archived-At: > From: Tassilo Horn > Date: Tue, 05 Feb 2019 14:21:46 +0100 > Cc: emacs-devel@gnu.org > > I just became aware of the fact that we cannot use > `replace-buffer-contents' in its current state if the replacement is too > large. It becomes unbearable slow. In what version of Emacs? I think it was slow in 26.1, but wa ssped up significantly since then. If you are using emacs-26 or the master branch from Git, and it is still slow, can you show an example where it's slow, and tell how much time it took? > I wonder where and how to fix that. Maybe `replace-buffer-contents' > could fall back to recognize itself if it doesn't make sense to try to > restore point and marks, e.g., trivial cases like point is on > (point-min) or (point-max) and there are no marks, or the replacement > buffer's content exceeds some maximum... AFAIR, the speed of replace-buffer-contents doesn't depend at all on whether markers are preserved or not, so I don't think this will matter.