From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer Date: Fri, 01 Mar 2019 12:07:24 +0200 Message-ID: <83k1hij4bn.fsf@gnu.org> References: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> <838syho4xg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="234018"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34479@debbugs.gnu.org, daniel.lopez999@gmail.com To: Tobias Bading Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 01 11:13:05 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzfA7-000ye9-B0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2019 11:13:03 +0100 Original-Received: from localhost ([127.0.0.1]:34751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzfA6-0001oU-8h for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Mar 2019 05:13:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzf5K-0006Om-5e for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 05:08:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzf5I-0004SQ-4i for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 05:08:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gzf5H-0004Rw-Ts for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 05:08:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gzf5F-0004Wy-T5 for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2019 05:08:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Mar 2019 10:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34479 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34479-submit@debbugs.gnu.org id=B34479.155143486817397 (code B ref 34479); Fri, 01 Mar 2019 10:08:01 +0000 Original-Received: (at 34479) by debbugs.gnu.org; 1 Mar 2019 10:07:48 +0000 Original-Received: from localhost ([127.0.0.1]:55808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzf52-0004WX-E9 for submit@debbugs.gnu.org; Fri, 01 Mar 2019 05:07:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gzf50-0004WK-W4 for 34479@debbugs.gnu.org; Fri, 01 Mar 2019 05:07:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzf4s-00047C-L5; Fri, 01 Mar 2019 05:07:39 -0500 Original-Received: from [176.228.60.248] (port=1140 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzf4s-0003WH-8r; Fri, 01 Mar 2019 05:07:38 -0500 In-reply-to: (message from Tobias Bading on Mon, 25 Feb 2019 14:26:38 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155921 Archived-At: > From: Tobias Bading > Date: Mon, 25 Feb 2019 14:26:38 +0100 > Cc: Daniel Lopez , > Eli Zaretskii > > I also discovered this bug a few days ago and came up with the same fix as Daniel. However, there’s a small mistake in his patch which results in incorrect error numbers in the mode line. The compilation--note-type call should look like this: > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index 146af5a..368b088 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -1441,7 +1441,7 @@ compilation-parse-errors > (let ((this-type (if (consp type) > (compilation-type type) > (or type 2)))) > - (compilation--note-type type) > + (compilation--note-type this-type) > > (compilation--put-prop > file 'font-lock-face Thanks, pushed to the emacs-26 branch.