From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35058: [PATCH] Use display-graphic-p in more cases Date: Fri, 05 Apr 2019 21:51:43 +0300 Message-ID: <83k1g8b800.fsf@gnu.org> References: <8736n4ndav.fsf@gmail.com> <83tvfjgilm.fsf@gnu.org> <875zry9x94.fsf@gmail.com> <83a7hagv11.fsf@gnu.org> <87d0m4pcca.fsf@gmail.com> <83ef6kfhjf.fsf@gnu.org> <878swsp9wh.fsf@gmail.com> <838swsfdzb.fsf@gnu.org> <87r2ajbrhd.fsf@gmail.com> <83pnq3ejxe.fsf@gnu.org> <87h8be7s3t.fsf@gmail.com> <838swodi54.fsf@gnu.org> <87k1g8csve.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="265681"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35058@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 05 20:54:38 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCTz3-0016zr-7L for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 20:54:37 +0200 Original-Received: from localhost ([127.0.0.1]:45667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCTz2-0001Zp-9p for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 14:54:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCTyv-0001Zc-KD for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 14:54:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCTyp-0003nx-3b for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 14:54:27 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60988) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCTxX-0002aO-TW for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 14:54:22 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCTxW-0000kG-Df for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 14:53:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2019 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35058 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35058-submit@debbugs.gnu.org id=B35058.15544903552826 (code B ref 35058); Fri, 05 Apr 2019 18:53:02 +0000 Original-Received: (at 35058) by debbugs.gnu.org; 5 Apr 2019 18:52:35 +0000 Original-Received: from localhost ([127.0.0.1]:46299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCTx4-0000jW-T7 for submit@debbugs.gnu.org; Fri, 05 Apr 2019 14:52:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCTx1-0000jH-V3 for 35058@debbugs.gnu.org; Fri, 05 Apr 2019 14:52:32 -0400 Original-Received: from fencepost.gnu.org ([209.51.188.10]:39886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCTwT-0001Ir-J4; Fri, 05 Apr 2019 14:52:19 -0400 Original-Received: from [176.228.60.248] (port=4957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hCTwR-00010D-LH; Fri, 05 Apr 2019 14:51:56 -0400 In-reply-to: <87k1g8csve.fsf@gmail.com> (message from Alex on Fri, 05 Apr 2019 10:35:33 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157231 Archived-At: > From: Alex > Cc: 35058@debbugs.gnu.org > Date: Fri, 05 Apr 2019 10:35:33 -0600 > > Okay, here's a new set of patches (excluding the same logb patch). Thanks, this LGTM, with a couple of nits: > +** CUA mode > + > +*** New defcustom 'cua-rectangle-terminal-modifier-key' Please add a period at the end of this sentence. > +This defcustom is used instead of forcing the modifier key to I'd say "allows to customize the modifier key ..." instead of "is used instead of ...". Also, please mark this entry with "---", as it doesn't need to be documented in any manuals. (The other NEWS entry as well.)