all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alex <agrambot@gmail.com>
Cc: 35058@debbugs.gnu.org
Subject: bug#35058: [PATCH] Use display-graphic-p in more cases
Date: Fri, 05 Apr 2019 21:51:43 +0300	[thread overview]
Message-ID: <83k1g8b800.fsf@gnu.org> (raw)
In-Reply-To: <87k1g8csve.fsf@gmail.com> (message from Alex on Fri, 05 Apr 2019 10:35:33 -0600)

> From: Alex <agrambot@gmail.com>
> Cc: 35058@debbugs.gnu.org
> Date: Fri, 05 Apr 2019 10:35:33 -0600
> 
> Okay, here's a new set of patches (excluding the same logb patch).

Thanks, this LGTM, with a couple of nits:

> +** CUA mode
> +
> +*** New defcustom 'cua-rectangle-terminal-modifier-key'

Please add a period at the end of this sentence.

> +This defcustom is used instead of forcing the modifier key to

I'd say "allows to customize the modifier key ..." instead of "is used
instead of ...".

Also, please mark this entry with "---", as it doesn't need to be
documented in any manuals.  (The other NEWS entry as well.)





  reply	other threads:[~2019-04-05 18:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30 23:38 bug#35058: [PATCH] Use display-graphic-p in more cases Alex
2019-03-31 12:45 ` Basil L. Contovounesios
2019-03-31 15:37 ` Eli Zaretskii
2019-04-01  4:15   ` Alex
2019-04-01  5:21     ` Eli Zaretskii
2019-04-02 17:05       ` Alex
2019-04-02 17:23         ` Eli Zaretskii
2019-04-02 17:57           ` Alex
2019-04-02 18:39             ` Eli Zaretskii
2019-04-03  5:14               ` Alex
2019-04-03  5:29                 ` Eli Zaretskii
2019-04-03 20:26                   ` Alex
2019-04-05  7:29                     ` Eli Zaretskii
2019-04-05 16:35                       ` Alex
2019-04-05 18:51                         ` Eli Zaretskii [this message]
2019-04-07  5:11                           ` Alex
     [not found]     ` <<83a7hagv11.fsf@gnu.org>
2019-04-01 14:32       ` Drew Adams
2019-04-06  7:18         ` Eli Zaretskii
2019-04-07 13:50     ` Stefan Monnier
     [not found] <<8736n4ndav.fsf@gmail.com>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k1g8b800.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=35058@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.