From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Sat, 13 Apr 2019 22:19:12 +0300 Message-ID: <83k1fxk91r.fsf@gnu.org> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> <1555180119.2579.0@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="242420"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 13 21:20:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFOCL-0010ie-HV for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 21:20:21 +0200 Original-Received: from localhost ([127.0.0.1]:55074 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFOCB-0003zn-Or for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 15:20:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFOC3-0003zR-FP for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 15:20:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFOC2-0006a4-HW for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 15:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFOC2-0006Zi-AJ for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 15:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hFOC1-00088W-W3 for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2019 19:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155518317531233 (code B ref 35062); Sat, 13 Apr 2019 19:20:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 13 Apr 2019 19:19:35 +0000 Original-Received: from localhost ([127.0.0.1]:59222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFOBa-00087g-LW for submit@debbugs.gnu.org; Sat, 13 Apr 2019 15:19:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFOBY-00087T-NK for 35062@debbugs.gnu.org; Sat, 13 Apr 2019 15:19:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFOBR-000690-SN; Sat, 13 Apr 2019 15:19:27 -0400 Original-Received: from [176.228.60.248] (port=2527 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hFOBR-0003VI-Cr; Sat, 13 Apr 2019 15:19:25 -0400 In-reply-to: <1555180119.2579.0@yandex.ru> (message from Konstantin Kharlamov on Sat, 13 Apr 2019 21:28:39 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157590 Archived-At: > Date: Sat, 13 Apr 2019 21:28:39 +0300 > From: Konstantin Kharlamov > Cc: 35062@debbugs.gnu.org > > >> http://git.savannah.gnu.org/cgit/emacs.git/log/?qt=author&q=Konstantin > >> there is no my contribution. > >> > >> More over: you didn't even tell me! Wow! This is not good. > > > > What do you mean? Your name is in the log. > > If you click the link above you won't find it. The only mention of my > name is in log message as "suggested-by". If you are looking at partial information, don't be surprised that you see only some part of what was done and written. Emacs contributors are generally expected to have a clone of the repository on their local machine. Don't you have it? > Which btw sounds like I reported a bug "hey guys, I don't know how > to code, but static analyzer says this part can be improved, can > anybody do it for me?". That's not what it means. "Suggested by" means you suggested a code change, but I tweaked it enough to feel that you can no longer be held responsible for whatever mistakes I might have made in the actual code change I committed. And I explicitly said that this is what I did: "I pushed a slightly different change along the same lines." There's also a reference to the bug number, where what you submitted is clearly visible. The "I don't know how to code" variant would have been identified as "reported by" instead. This is all standard practice around here (and in other projects as well).